Smalltalk › Squeak › Squeak - Dev

Where to publish minor clean-up ?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

Nicolas Cellier-3

Where to publish minor clean-up ?

A lot of methods seem duplicated like for example:

DecompilerConstructor>>codeTemp: index named: tempName
^ TempVariableNode new
name: tempName
index: index
type: LdTempType
scope: 0

DecompilerConstructor>>codeTemp: index
^ TempVariableNode new
name: 't' , (index + 1) printString
index: index
type: LdTempType
scope: 0

The second one should better be
^ self codeTemp: index named: 't' , (index + 1) printString

This is a very minor clean-up, i agree, but plenty of these can make code
smaller smarter easier to maintain...

So my question is where to publish such small pieces of code ?

Nicolas

SmallCleanUp.1.cs (275 bytes) Download Attachment

Ken Causey-3

Re: Where to publish minor clean-up ?

Whether it's one line or 1,000 it always goes to the same place:
http://bugs.impara.de/ .

Ken

P.S. Prefereably as a well filled out report specifying the category
based on the top-level class category of the relevant class and
including a clear explanation and a gzipped changeset.

On Mon, 2006-04-03 at 22:56 +0200, nicolas cellier wrote:

> A lot of methods seem duplicated like for example:
>
> DecompilerConstructor>>codeTemp: index named: tempName
> ^ TempVariableNode new
> name: tempName
> index: index
> type: LdTempType
> scope: 0
>
> DecompilerConstructor>>codeTemp: index
> ^ TempVariableNode new
> name: 't' , (index + 1) printString
> index: index
> type: LdTempType
> scope: 0
>
> The second one should better be
> ^ self codeTemp: index named: 't' , (index + 1) printString
>
> This is a very minor clean-up, i agree, but plenty of these can make code
> smaller smarter easier to maintain...
>
> So my question is where to publish such small pieces of code ?
>
> Nicolas

signature.asc (198 bytes) Download Attachment