Won't compile if not run extract-commit-info.sh

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Won't compile if not run extract-commit-info.sh

Mariano Martinez Peck
 
Hi (Igor?). Nowadays, if you don't execute (by hand) ./codegen-scripts/extract-commit-info.sh  then the VM will simply don't compile.
So...can we somehow attach this to the makefiles or cmake so that it automatically executes it? 

Thanks

--
Mariano
http://marianopeck.wordpress.com

Reply | Threaded
Open this post in threaded view
|

Re: Won't compile if not run extract-commit-info.sh

Igor Stasenko

On 7 December 2011 20:38, Mariano Martinez Peck <[hidden email]> wrote:
>
> Hi (Igor?). Nowadays, if you don't execute (by hand) ./codegen-scripts/extract-commit-info.sh  then the VM will simply don't compile.
> So...can we somehow attach this to the makefiles or cmake so that it automatically executes it?
>

well, it should be present in sources, which you download as tarball
archive from jenkins server.
the problem is that to extract a commit info, you need to have own git
repository clone, otherwise it won't work, obviously.
that's why for sources , which downloaded from tarball, this file is
already present.
putting it into cmake config, will mean that you can build VM only by
having git repo clone, and impossible to build without it.



--
Best regards,
Igor Stasenko.
Reply | Threaded
Open this post in threaded view
|

Re: Won't compile if not run extract-commit-info.sh

Mariano Martinez Peck
 


On Wed, Dec 7, 2011 at 10:46 PM, Igor Stasenko <[hidden email]> wrote:

On 7 December 2011 20:38, Mariano Martinez Peck <[hidden email]> wrote:
>
> Hi (Igor?). Nowadays, if you don't execute (by hand) ./codegen-scripts/extract-commit-info.sh  then the VM will simply don't compile.
> So...can we somehow attach this to the makefiles or cmake so that it automatically executes it?
>

well, it should be present in sources, which you download as tarball
archive from jenkins server.

Yes, but I am building from VMMAker ;)
 
the problem is that to extract a commit info, you need to have own git
repository clone, otherwise it won't work, obviously.
that's why for sources , which downloaded from tarball, this file is
already present.
putting it into cmake config, will mean that you can build VM only by
having git repo clone, and impossible to build without it.

Ok, BUT, isn't all this thing about CMakeVMMaker expected to work with the Git version?

Anyway, why it cannot just be optional? For example:

CogMTCocoaIOSConfig new
       generateForDebug;
       extractCommitInfo;
       generateSources; generate.

?
 



--
Best regards,
Igor Stasenko.



--
Mariano
http://marianopeck.wordpress.com

Reply | Threaded
Open this post in threaded view
|

Re: Won't compile if not run extract-commit-info.sh

Igor Stasenko

On 7 December 2011 23:50, Mariano Martinez Peck <[hidden email]> wrote:

>
>
>
> On Wed, Dec 7, 2011 at 10:46 PM, Igor Stasenko <[hidden email]> wrote:
>>
>>
>> On 7 December 2011 20:38, Mariano Martinez Peck <[hidden email]> wrote:
>> >
>> > Hi (Igor?). Nowadays, if you don't execute (by hand) ./codegen-scripts/extract-commit-info.sh  then the VM will simply don't compile.
>> > So...can we somehow attach this to the makefiles or cmake so that it automatically executes it?
>> >
>>
>> well, it should be present in sources, which you download as tarball
>> archive from jenkins server.
>
>
> Yes, but I am building from VMMAker ;)
>
>>
>> the problem is that to extract a commit info, you need to have own git
>> repository clone, otherwise it won't work, obviously.
>> that's why for sources , which downloaded from tarball, this file is
>> already present.
>> putting it into cmake config, will mean that you can build VM only by
>> having git repo clone, and impossible to build without it.
>
>
> Ok, BUT, isn't all this thing about CMakeVMMaker expected to work with the Git version?
>
it is expected to work with sources from git. but not necessary you
need to have a full clone of git repository.
anyways i think it doesn't makes much difference today :)

> Anyway, why it cannot just be optional? For example:
>
> CogMTCocoaIOSConfig new
>        generateForDebug;
>        extractCommitInfo;
>        generateSources; generate.
>

good idea. :)

> ?
>

--
Best regards,
Igor Stasenko.
Reply | Threaded
Open this post in threaded view
|

Re: Won't compile if not run extract-commit-info.sh

Mariano Martinez Peck
 

> Anyway, why it cannot just be optional? For example:
>
> CogMTCocoaIOSConfig new
>        generateForDebug;
>        extractCommitInfo;
>        generateSources; generate.
>

good idea. :)


But how can I implement #extractCommitInfo?   hahahahhaha
I don't know how I could attach such execution inside cmake or makefile...do you?

 
> ?
>

--
Best regards,
Igor Stasenko.



--
Mariano
http://marianopeck.wordpress.com

Reply | Threaded
Open this post in threaded view
|

Re: Won't compile if not run extract-commit-info.sh

Igor Stasenko

On 8 December 2011 11:15, Mariano Martinez Peck <[hidden email]> wrote:

>
>
>> > Anyway, why it cannot just be optional? For example:
>> >
>> > CogMTCocoaIOSConfig new
>> >        generateForDebug;
>> >        extractCommitInfo;
>> >        generateSources; generate.
>> >
>>
>> good idea. :)
>>
>
> But how can I implement #extractCommitInfo?   hahahahhaha
> I don't know how I could attach such execution inside cmake or makefile...do you?
>
>
Google for:
"cmake custom command"

i am using it in couple places already :)

--
Best regards,
Igor Stasenko.