another Compression question

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

another Compression question

Chris Muller-3
I've just noticed that, whenever I create a zip file in Squeak, the
timestamps of the Directory members are the year 2038.

It looks perhaps like the recent change to
ZipArchiveMember>>#setLastModFileDateTimeFrom: might be the culprit.

Does anyone ("jdr"?) know why this method from 2001 was changed?

Thanks,
  Chris

Reply | Threaded
Open this post in threaded view
|

Re: another Compression question

Javier Diaz-Reinoso
That's me, the patch try to simplify a time conversion, the original code was using DOS<->unix<->squeakDate conversions, instead I added squeakToDosTime: and dosToSqueakTime: to convert DOS<->squeakDate, because the unix conversion fails with certain dates like 29/Feb/2000 (a 2K bug).

I think you are seeing another bug, I can't test in this moment in my mac because I am seeing another bug(s), one with a .DS_STORE entry (an apple hidden directory) and another when I try to add a directory using the button I have a 'subscript is out of bounds: 0' error, this because any directory have a modification date of 0.

On 19/09/2010, at 16:14, Chris Muller wrote:

> I've just noticed that, whenever I create a zip file in Squeak, the
> timestamps of the Directory members are the year 2038.
>
> It looks perhaps like the recent change to
> ZipArchiveMember>>#setLastModFileDateTimeFrom: might be the culprit.
>
> Does anyone ("jdr"?) know why this method from 2001 was changed?
>
> Thanks,
>  Chris
>