Smalltalk › Squeak › Squeak VM

[commit][3225] Fix the include of reConfig.h in RePlugin's internal.h

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

commits-3

[commit][3225] Fix the include of reConfig.h in RePlugin's internal.h

Revision: 3225
Author: eliot
Date: 2015-01-09 13:59:06 -0800 (Fri, 09 Jan 2015)
Log Message:
-----------
Fix the include of reConfig.h in RePlugin's internal.h

Modified Paths:
--------------
trunk/platforms/Cross/plugins/RePlugin/internal.h

Property Changed:
----------------
trunk/platforms/Cross/plugins/sqPluginsSCCSVersion.h

Modified: trunk/platforms/Cross/plugins/RePlugin/internal.h
===================================================================
--- trunk/platforms/Cross/plugins/RePlugin/internal.h 2015-01-09 21:02:25 UTC (rev 3224)
+++ trunk/platforms/Cross/plugins/RePlugin/internal.h 2015-01-09 21:59:06 UTC (rev 3225)
@@ -40,7 +40,7 @@
#define NEWLINE '\r'
#define SQUEAK_PLUGIN

-#include "reconfig.h"
+#include "reConfig.h"

/* To cope with SunOS4 and other systems that lack memmove() but have bcopy(),
define a macro for memmove() if HAVE_MEMMOVE is false, provided that HAVE_BCOPY

Property changes on: trunk/platforms/Cross/plugins/sqPluginsSCCSVersion.h
___________________________________________________________________
Modified: checkindate
- Wed Jan 7 16:41:51 PST 2015
+ Fri Jan 9 13:59:25 PST 2015

David T. Lewis

Re: [commit][3225] Fix the include of reConfig.h in RePlugin's internal.h

On Fri, Jan 09, 2015 at 01:59:09PM -0800, [hidden email] wrote:
>
> Revision: 3225
> Author: eliot
> Date: 2015-01-09 13:59:06 -0800 (Fri, 09 Jan 2015)
> Log Message:
> -----------
> Fix the include of reConfig.h in RePlugin's internal.h
>

Thanks Eliot,

I was just sitting down to find the cause of the failures on
http://build.squeak.org/job/InterpreterVM/ when I saw this update.
Back to green again :-)

Dave

Eliot Miranda-2

Re: [commit][3225] Fix the include of reConfig.h in RePlugin's internal.h

On Fri, Jan 9, 2015 at 3:50 PM, David T. Lewis <[hidden email]> wrote:

On Fri, Jan 09, 2015 at 01:59:09PM -0800, [hidden email] wrote:
>
> Revision: 3225
> Author: eliot
> Date: 2015-01-09 13:59:06 -0800 (Fri, 09 Jan 2015)
> Log Message:
> -----------
> Fix the include of reConfig.h in RePlugin's internal.h
>

Thanks Eliot,

I was just sitting down to find the cause of the failures on
http://build.squeak.org/job/InterpreterVM/ when I saw this update.
Back to green again :-)

Phew :-) I saw much the same thing at the Cadence CI. The issue is platforms/Cross/plugins and platforms/win32/plugins being external. I often forget to check those in. Of course, local builds just work, because they're looking at the local modifications. Sorry for the scare.

Dave

best,

Eliot

David T. Lewis

Re: [commit][3225] Fix the include of reConfig.h in RePlugin's internal.h

On Fri, Jan 09, 2015 at 03:53:33PM -0800, Eliot Miranda wrote:

>
> On Fri, Jan 9, 2015 at 3:50 PM, David T. Lewis <[hidden email]> wrote:
>
> >
> > On Fri, Jan 09, 2015 at 01:59:09PM -0800, [hidden email] wrote:
> > >
> > > Revision: 3225
> > > Author: eliot
> > > Date: 2015-01-09 13:59:06 -0800 (Fri, 09 Jan 2015)
> > > Log Message:
> > > -----------
> > > Fix the include of reConfig.h in RePlugin's internal.h
> > >
> >
> > Thanks Eliot,
> >
> > I was just sitting down to find the cause of the failures on
> > http://build.squeak.org/job/InterpreterVM/ when I saw this update.
> > Back to green again :-)
> >
>
> Phew :-) I saw much the same thing at the Cadence CI. The issue is
> platforms/Cross/plugins and platforms/win32/plugins being external. I
> often forget to check those in. Of course, local builds just work, because
> they're looking at the local modifications. Sorry for the scare.
>

I'm just glad that I procrastinated for a few days until somebody else
got around to fixing it for me. Sort of like that whole box2 thing ;-)

(btw, I hope folks realize what an amazing job that Levente, Tobias,
and others have been doing in bringing us back on line after the box2
disk failure. Really impressive teamwork.)

Dave