Smalltalk › Squeak › Squeak VM

[commit] r2418 - Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

commits-3

[commit] r2418 - Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.

Author: andreas
Date: 2011-06-09 02:10:34 -0700 (Thu, 09 Jun 2011)
New Revision: 2418

Removed:
branches/Cog/platforms/Cross/plugins/
Modified:
branches/Cog/platforms/Cross/
Log:
Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.

Property changes on: branches/Cog/platforms/Cross
___________________________________________________________________
Added: svn:externals
+ http://squeakvm.org/svn/squeak/trunk/platforms/Cross/plugins plugins

Igor Stasenko

Re: [commit] r2418 - Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.

Does it changes the way how svn checkout works?
If i will checkout
branches/Cog,
will it do same as before,
or i will need to do separate checkout of
trunk/platforms/Cross/plugins?

On 9 June 2011 11:10, <[hidden email]> wrote:

>
> Author: andreas
> Date: 2011-06-09 02:10:34 -0700 (Thu, 09 Jun 2011)
> New Revision: 2418
>
> Removed:
> branches/Cog/platforms/Cross/plugins/
> Modified:
> branches/Cog/platforms/Cross/
> Log:
> Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.
>
>
> Property changes on: branches/Cog/platforms/Cross
> ___________________________________________________________________
> Added: svn:externals
> + http://squeakvm.org/svn/squeak/trunk/platforms/Cross/plugins plugins
>
>
>

--
Best regards,
Igor Stasenko AKA sig.

Andreas.Raab

Re: [commit] r2418 - Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.

On 6/9/2011 16:19, Igor Stasenko wrote:
>
> Does it changes the way how svn checkout works?
> If i will checkout
> branches/Cog,
> will it do same as before,
> or i will need to do separate checkout of
> trunk/platforms/Cross/plugins?

Short answer: Try it :-)

Longer answer: It doesn't change anything. Google svn:externals for more
info.

Cheers,
- Andreas

> On 9 June 2011 11:10,<[hidden email]> wrote:
>> Author: andreas
>> Date: 2011-06-09 02:10:34 -0700 (Thu, 09 Jun 2011)
>> New Revision: 2418
>>
>> Removed:
>> branches/Cog/platforms/Cross/plugins/
>> Modified:
>> branches/Cog/platforms/Cross/
>> Log:
>> Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.
>>
>>
>> Property changes on: branches/Cog/platforms/Cross
>> ___________________________________________________________________
>> Added: svn:externals
>> + http://squeakvm.org/svn/squeak/trunk/platforms/Cross/plugins plugins
>>
>>
>>
>
>

Igor Stasenko

Re: [commit] r2418 - Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.

On 9 June 2011 16:48, Andreas Raab <[hidden email]> wrote:

>
> On 6/9/2011 16:19, Igor Stasenko wrote:
>>
>> Does it changes the way how svn checkout works?
>> If i will checkout
>> branches/Cog,
>> will it do same as before,
>> or i will need to do separate checkout of
>> trunk/platforms/Cross/plugins?
>
> Short answer: Try it :-)
>
> Longer answer: It doesn't change anything. Google svn:externals for more
> info.
>
> Cheers,
> - Andreas

So, with this change, the Cog and Squeak cross-platform plugins
codebase are now same, right?
This is good. Less things to worry about.

--
Best regards,
Igor Stasenko AKA sig.

Andreas.Raab

Re: [commit] r2418 - Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.

On 6/9/2011 17:25, Igor Stasenko wrote:

>
> On 9 June 2011 16:48, Andreas Raab<[hidden email]> wrote:
>> On 6/9/2011 16:19, Igor Stasenko wrote:
>>> Does it changes the way how svn checkout works?
>>> If i will checkout
>>> branches/Cog,
>>> will it do same as before,
>>> or i will need to do separate checkout of
>>> trunk/platforms/Cross/plugins?
>> Short answer: Try it :-)
>>
>> Longer answer: It doesn't change anything. Google svn:externals for more
>> info.
>>
>> Cheers,
>> - Andreas
> So, with this change, the Cog and Squeak cross-platform plugins
> codebase are now same, right?

Yes, the Cross and the win32 plugin sources are now identical between
interp and Cog branch.

> This is good. Less things to worry about.

Indeed. The plan is to keep going incrementally until there are no
differences left. At which point we might consider a slightly different
layout of the sources for building interp, stackvm, and Cog
side-by-side, but let's start with merging the support code first.

Cheers,
- Andreas

Eliot Miranda-2

Re: [commit] r2418 - Delete branches/Cog/platforms/Cross/plugins and replace it with an svn:external to trunk/platforms/Cross/plugins.

On Thu, Jun 9, 2011 at 8:38 AM, Andreas Raab <[hidden email]> wrote:

On 6/9/2011 17:25, Igor Stasenko wrote:

On 9 June 2011 16:48, Andreas Raab<[hidden email]> wrote:

On 6/9/2011 16:19, Igor Stasenko wrote:

Does it changes the way how svn checkout works?
If i will checkout
branches/Cog,
will it do same as before,
or i will need to do separate checkout of
trunk/platforms/Cross/plugins?

Short answer: Try it :-)

Longer answer: It doesn't change anything. Google svn:externals for more
info.

Cheers,
- Andreas

So, with this change, the Cog and Squeak cross-platform plugins
codebase are now same, right?

Yes, the Cross and the win32 plugin sources are now identical between interp and Cog branch.

This is good. Less things to worry about.

Indeed. The plan is to keep going incrementally until there are no differences left. At which point we might consider a slightly different layout of the sources for building interp, stackvm, and Cog side-by-side, but let's start with merging the support code first.

Agreed. Looking forward, one thing we might want ot do is externalize the mapping of plugin classes to plugins. What I mean is that currently in VMMaker a plugin class can choose its plugin name, so that e.g. all of FFIPlugin ReentrantFFIPlugin ThreadedFFIPlugin ReentrantARMFFIPlugin ReentrantIA32FFIPlugin ReentrantPPCBEFFIPlugin ThreadedARMFFIPlugin ThreadedIA32FFIPlugin ThreadedPPCBEFFIPlugin have a moduleName of 'SqueakFFIPrims'. What this means is that the sources /can't/ contain the different plugins. So, a) I can't have one source tree containing code for different ISAs, x86, x86-64, PPC and ARM, and b) I can't have one source tree containing important variants such as ReentrantIA32FFIPlugin (for the non-thrreaded VM) and ThreadedIA32FFIPlugin (for the threaded VM). If instead, the mapping from class name to module name is done in the platforms tree and/or makefiles somehow, then there's no obstacle to doing what I want, which is include the threaded and non-threaded VMs side-by-side.

Anyway, just an issue to be addressed sometime, but not before sources are merged.

best,

Eliot

Cheers,
- Andreas