different behaviour with MenuMorph

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

different behaviour with MenuMorph

Enno Schwass
Hi

Its not a problem with omnibrowser itself, but its best demonstrated  
with

I often work with omni browser using its cool refactoring methods.  
But sometimes it
breaks my workflow. Why? The context menu in the class panel allows  
me to choose
different actions (from "file out" to "refactor instance variable").  
If I move the
hand (mouse) downwards and accidently leave the menu on the bottom,  
the menu
is still there, but mouse focus is lost. I can get back the focus  
with clicking (and not
releasing) on a certain item. Thanks to KenCausey for this hint. But  
this is not really the
behaviour I like. I wanna have mouse focus if I enter the menu area.  
You can see this
behaviour in the world menu. (left click on the background). Move  
around with the mouse.
It works. Try Ctrl-leftMouse on the background (or middle mouse) and  
you get a different
menu that has the buggy behaviour. So its different behaviour  
depending on the mouse
button you use to open a menu.

Dont know if this is a feature. Can I turn off this?

Thanks
Enno

Reply | Threaded
Open this post in threaded view
|

Re: different behaviour with MenuMorph

Tom Phoenix
On Jan 4, 2008 5:29 PM, Enno Schwass <[hidden email]> wrote a long
description that seemed to be about this: Control-click on the Squeak
desktop to bring up a menu, then move the mouse off of the menu across
the menu's lower edge; the menu loses mouse focus.

> Dont know if this is a feature. Can I turn off this?

I think it's safe to say that it's a bug. What seems to be happening
is that there are a number of sub-menus near the bottom of that menu;
when the mouse leaves the last menu item but fails to transfer to its
sub-menu, the hand loses focus on the original menu.

Note that the menu is still completely functional; even though it's no
longer tracking the mouse, you can still use the mouse to click an
item.

The bug seems to be in MenuItemMorph>>deselectTimeOut:, which sets the
mouse focus to nil. Does changing that from nil to owner do what you
want?

  deselectTimeOut: evt
    "Deselect timout. Now really deselect"
    owner selectedItem == self
        ifTrue:[
            evt hand newMouseFocus: owner.
            owner selectItem: nil event: evt].

Here's the bug report I've put on Mantis:

    http://bugs.squeak.org/view.php?id=6846

Hope this helps!

--Tom Phoenix

Reply | Threaded
Open this post in threaded view
|

Re: different behaviour with MenuMorph

Enno Schwass
Hello

> I think it's safe to say that it's a bug. What seems to be happening
> is that there are a number of sub-menus near the bottom of that menu;
> when the mouse leaves the last menu item but fails to transfer to its
> sub-menu, the hand loses focus on the original menu.
> The bug seems to be in MenuItemMorph>>deselectTimeOut:, which sets the
> mouse focus to nil. Does changing that from nil to owner do what you
> want?
>
>   deselectTimeOut: evt
>     "Deselect timout. Now really deselect"
>     owner selectedItem == self
>         ifTrue:[
>             evt hand newMouseFocus: owner.
>             owner selectItem: nil event: evt].

Great. Thats it. Thanks for the fix and the mantis report.
I hope this will be included as standard behaviour in the image soon.

bye
Enno

Reply | Threaded
Open this post in threaded view
|

Re: different behaviour with MenuMorph

Damien Cassou-3
In reply to this post by Tom Phoenix
On Jan 10, 2008 5:25 AM, Tom Phoenix <[hidden email]> wrote:
> Here's the bug report I've put on Mantis:
>
>     http://bugs.squeak.org/view.php?id=6846

I confirm the bug and the fix.


--
Damien Cassou

Reply | Threaded
Open this post in threaded view
|

Re: different behaviour with MenuMorph

keith1y
Damien Cassou wrote:
> On Jan 10, 2008 5:25 AM, Tom Phoenix <[hidden email]> wrote:
>  
>> Here's the bug report I've put on Mantis:
>>
>>     http://bugs.squeak.org/view.php?id=6846
>>    
>
> I confirm the bug and the fix.
>  
Hello Damien and anyone else interested in working on > 3.10

Since 3.10 is approaching absolute "final final final", I have added
this fix to the page
http://installer.pbwiki.com/MinorFixesUnstable-Squeak3.10

This is a list of pending fixes that may be applied to a
LevelPlayingField image, like so...

Installer install: 'LatestUnstable'. "or"
Installer install: 'MinorFixesUnstable'.

After some testing we can move fixes to the Stable branch...

I would like to define the process a bit:

At some point we will decide to move fixes from
MinorFixesUnstable-Squeak3.10 into MinorFixes-Squeak3.10 at which point
they are considered to be a basic set of fixes that a 3.10 image may
benefit from. I propose this two step process because this is a set of
fixes that should be appropriate for building a 3.10 image for use in
production therefore it makes sense to have a defined review stage.

A future release of 3.10.1 could be a LevelPlayingField image with all
collated MinorFixes and Updates. With this process 3.9.1 may be a
similarly defined LevelPlayingField image with its MinorFixes and
Updates applied.

Anyone who uses an earlier image (say 3.8.2) who feels the need to
retro-fit a fix can do so by copying the fix into
"MinorFixes-Squeak3:8:2". It will then be available to users of 3.8.2,
by executing Installer install: 'MinorFixes'.

However we dont want to go mad with this, so I propose to ask for
volunteers to be "Version czar's" to monitor the minor fixes that exist
for each version of squeak. Whoever released 3.8.2 (I dont know who that
is) might want to be the version czar for 3.8.  Since individual
packages that need fixes in order to load into specific older images can
define their own version specific installs, there is a place to put
"fixes as needed". It is not necessary to retro fit lots of fixes into
older images. But it does make sense (to me at least) to have a place to
put some fixes, and someone to look after each version.

By the way, this process is now open to anyone to contribute to the
MinorFixesUnstable branch. The password for the wiki is "squeak", please
feel free to join in. If you do, please pop into irc #squeak and
announce/discuss the changes that you are making.

best regards

Keith











Reply | Threaded
Open this post in threaded view
|

Re: different behaviour with MenuMorph

Damien Cassou-3
Hi Keith,

this sounds interesting but the webpage is not accessible
http://installer.pbwiki.com/MinorFixesUnstable-Squeak3.10.

On Jan 11, 2008 9:57 AM, Keith Hodges <[hidden email]> wrote:

>
> Damien Cassou wrote:
> > On Jan 10, 2008 5:25 AM, Tom Phoenix <[hidden email]> wrote:
> >
> >> Here's the bug report I've put on Mantis:
> >>
> >>     http://bugs.squeak.org/view.php?id=6846
> >>
> >
> > I confirm the bug and the fix.
> >
> Hello Damien and anyone else interested in working on > 3.10
>
> Since 3.10 is approaching absolute "final final final", I have added
> this fix to the page
> http://installer.pbwiki.com/MinorFixesUnstable-Squeak3.10
>
> This is a list of pending fixes that may be applied to a
> LevelPlayingField image, like so...
>
> Installer install: 'LatestUnstable'. "or"
> Installer install: 'MinorFixesUnstable'.
>
> After some testing we can move fixes to the Stable branch...
>
> I would like to define the process a bit:
>
> At some point we will decide to move fixes from
> MinorFixesUnstable-Squeak3.10 into MinorFixes-Squeak3.10 at which point
> they are considered to be a basic set of fixes that a 3.10 image may
> benefit from. I propose this two step process because this is a set of
> fixes that should be appropriate for building a 3.10 image for use in
> production therefore it makes sense to have a defined review stage.
>
> A future release of 3.10.1 could be a LevelPlayingField image with all
> collated MinorFixes and Updates. With this process 3.9.1 may be a
> similarly defined LevelPlayingField image with its MinorFixes and
> Updates applied.
>
> Anyone who uses an earlier image (say 3.8.2) who feels the need to
> retro-fit a fix can do so by copying the fix into
> "MinorFixes-Squeak3:8:2". It will then be available to users of 3.8.2,
> by executing Installer install: 'MinorFixes'.
>
> However we dont want to go mad with this, so I propose to ask for
> volunteers to be "Version czar's" to monitor the minor fixes that exist
> for each version of squeak. Whoever released 3.8.2 (I dont know who that
> is) might want to be the version czar for 3.8.  Since individual
> packages that need fixes in order to load into specific older images can
> define their own version specific installs, there is a place to put
> "fixes as needed". It is not necessary to retro fit lots of fixes into
> older images. But it does make sense (to me at least) to have a place to
> put some fixes, and someone to look after each version.
>
> By the way, this process is now open to anyone to contribute to the
> MinorFixesUnstable branch. The password for the wiki is "squeak", please
> feel free to join in. If you do, please pop into irc #squeak and
> announce/discuss the changes that you are making.
>
> best regards
>
> Keith
>
>
>
>
>
>
>
>
>
>
>
>



--
Damien Cassou

Reply | Threaded
Open this post in threaded view
|

Re: different behaviour with MenuMorph

keith1y
Damien Cassou wrote:
> Hi Keith,
>
> this sounds interesting but the webpage is not accessible
> http://installer.pbwiki.com/MinorFixesUnstable-Squeak3.10.
>
>  
 Hi Damien,

sorry it is

http://installer.pbwiki.com/MinorFixesUnstable-Squeak3:10

since pbwiki does not accept $. in urls

Keith