duplicated (identical) code: EToys/Morphic

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

duplicated (identical) code: EToys/Morphic

espin
Hi,
I found that the code of
   EToySystem class>>cleanupsForRelease
is an identical copy and past of
   StandardScriptingSystem>>cleanupsForRelease

Could it be useful to define instead as

EToySystem class>>cleanupsForRelease
        ScriptingSystem cleanupsForRelease

Maybe the above helps EToys' maintainers (Bert?)
Bye
Enrico

PS: ScriptingSystem is bound to an instance of StandardScriptingSystem
in StandardScriptingSystem class>>initialize
--
Enrico Spinielli
"Do Androids dream of electric sheep?"— Philip K. Dick
"Hear and forget; see and remember;do and understand."—Mitchel Resnick

Reply | Threaded
Open this post in threaded view
|

Re: duplicated (identical) code: EToys/Morphic

Levente Uzonyi-2
On Thu, 12 Aug 2010, Enrico Spinielli wrote:

> Hi,
> I found that the code of
>   EToySystem class>>cleanupsForRelease
> is an identical copy and past of
>   StandardScriptingSystem>>cleanupsForRelease

I'm pretty sure these are obsolete, since cleanup is now implemented in a
distributed way by #cleanUp:. ReleaseBuilder seems to be useless to...


Levente

>
> Could it be useful to define instead as
>
> EToySystem class>>cleanupsForRelease
> ScriptingSystem cleanupsForRelease
>
> Maybe the above helps EToys' maintainers (Bert?)
> Bye
> Enrico
>
> PS: ScriptingSystem is bound to an instance of StandardScriptingSystem
> in StandardScriptingSystem class>>initialize
> --
> Enrico Spinielli
> "Do Androids dream of electric sheep?"˙˙ Philip K. Dick
> "Hear and forget; see and remember;do and understand."˙˙Mitchel Resnick
>
>

Reply | Threaded
Open this post in threaded view
|

Re: duplicated (identical) code: EToys/Morphic

Bert Freudenberg

On 12.08.2010, at 23:22, Levente Uzonyi wrote:

> On Thu, 12 Aug 2010, Enrico Spinielli wrote:
>
>> Hi,
>> I found that the code of
>>  EToySystem class>>cleanupsForRelease
>> is an identical copy and past of
>>  StandardScriptingSystem>>cleanupsForRelease
>
> I'm pretty sure these are obsolete, since cleanup is now implemented in a distributed way by #cleanUp:. ReleaseBuilder seems to be useless to...
>
>
> Levente

Yep.

- Bert -

>>
>> Could it be useful to define instead as
>>
>> EToySystem class>>cleanupsForRelease
>> ScriptingSystem cleanupsForRelease
>>
>> Maybe the above helps EToys' maintainers (Bert?)
>> Bye
>> Enrico
>>
>> PS: ScriptingSystem is bound to an instance of StandardScriptingSystem
>> in StandardScriptingSystem class>>initialize
>> --
>> Enrico Spinielli
>> "Do Androids dream of electric sheep?"˙˙ Philip K. Dick
>> "Hear and forget; see and remember;do and understand."˙˙Mitchel Resnick
>>
>