Smalltalk › Squeak › Squeak VM

#isContext: is sent to self instead of objectMemory

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

alistairgrant

#isContext: is sent to self instead of objectMemory

Hi Eliot,

I think I've found a couple of typos:

- CoInterpreter>>ceNonLocalReturn:
- StackInterpreter>>commonReturn

both send #isContext: to self, while I think it should be sent to objectMemory.

Can you take a look at:

http://source.squeak.org/VMMakerInbox/VMMaker.oscog-akg.2487.mcz

and let me know what you think?

Thanks,
Alistair

Eliot Miranda-2

Re: #isContext: is sent to self instead of objectMemory

Hi Alistair, you're right. Push yours to trunk please. Well spotted!

On Thu, Nov 29, 2018 at 9:45 AM Alistair Grant <[hidden email]> wrote:

Hi Eliot,

I think I've found a couple of typos:

- CoInterpreter>>ceNonLocalReturn:
- StackInterpreter>>commonReturn

both send #isContext: to self, while I think it should be sent to objectMemory.

Can you take a look at:

http://source.squeak.org/VMMakerInbox/VMMaker.oscog-akg.2487.mcz

and let me know what you think?

Thanks,
Alistair

_,,,^..^,,,_

best, Eliot

alistairgrant

Re: #isContext: is sent to self instead of objectMemory

Hi Eliot,

On Thu, 29 Nov 2018 at 20:37, Eliot Miranda <[hidden email]> wrote:
>
>
> Hi Alistair, you're right. Push yours to trunk please. Well spotted!

Looks like you beat me to it...

Let me know if I've misread it.

Thanks,
Alistair

> On Thu, Nov 29, 2018 at 9:45 AM Alistair Grant <[hidden email]> wrote:
>>
>>
>> Hi Eliot,
>>
>> I think I've found a couple of typos:
>>
>> - CoInterpreter>>ceNonLocalReturn:
>> - StackInterpreter>>commonReturn
>>
>> both send #isContext: to self, while I think it should be sent to objectMemory.
>>
>> Can you take a look at:
>>
>> http://source.squeak.org/VMMakerInbox/VMMaker.oscog-akg.2487.mcz
>>
>> and let me know what you think?
>>
>> Thanks,
>> Alistair
>
>
>
> --
> _,,,^..^,,,_
> best, Eliot