patch: fix build failure when a plugin is excluded by more than one configure test

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

patch: fix build failure when a plugin is excluded by more than one configure test

Andrew Gaylard
 
Hi,

The attached patch fixes build failures caused when more than
one configure test causes the same plugin to be excluded from
the build.  In my case, it was the RomePlugin.  The build error
appears thus:

disabledPlugins.c:21: error: redefinition of 'RomePlugin_exports'
disabledPlugins.c:20: error: previous definition of
'RomePlugin_exports' was here

Again, this patch was made against the 3.10-4 source release,
but also applies cleanly against today's SVN tree.

Cheers,
Andrew Gaylard

PS: I see that the mailing list archives at
http://lists.squeakfoundation.org/pipermail/vm-dev/ has mangled
my last message (sent via gmail). I've switched to plain text now,
so hopefully, this one gets through.

PPS: Ian, some time ago you mentioned you'd apply my patches
[a] to build on Solaris, and [b] to fix the sound driver on Solaris.
I see that they're not in SVN; was there a problem with them?
Do you need me to resend them?

fix-duplicate-excluded-plugins.diff (2K) Download Attachment