patch for allocateBuffer in AsyncFilePlugin

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

patch for allocateBuffer in AsyncFilePlugin

stes
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Hi,

Is it please possible to fix a small issue in Squeak 4.19 (Classical VM).

On my system the compiler is complaining that a function has no return type:

file: platforms/unix/plugins/AsynchFilePlugin/sqUnixAsynchFile.c

"platforms/unix/plugins/AsynchFilePlugin/sqUnixAsynchFile.c", line 145: warning: no explicit type given
 
INLINE static allocateBuffer(struct FileBuf *buf, int size)

The function is used only once in that file, as in :

  if (!allocateBuffer(&fp->buf, count))

Please apply my patch (in attach) to the classical VM ...

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJgU1sLAAoJEAwpOKXMq1Ma4gwH/Rwte3vJraeRSh7kj/EkXBL+
+Ctus32dJQR5echOLrVwzouifIEFZj8lSn64DGQiQaE1ZNczizn6HDaCeGvSB7K2
GNbmg8Fxq1Ghts5WX9QaeeGEotptcHDGGkZf9oaQnr+qrx2CbLLz1MFk9Lg/B+In
sV2qL99vhFnS6kOjbpA926qj7Lb+bdsVg8ap7NO//t8UH6Irm7b4UMoRebJ68QpB
YpuqtvtFaWmNr03Hsh5pcgGzOAoC+MITIL5umaIcs6nla1so0J9GJ/gnxfPKEety
uo2kat03Onvjjn9FrwPi+qmmpq9hCDYMKFUqiV+OsYHWdfwGoXC6lKtSBgMvmGQ=
=Ukc3
-----END PGP SIGNATURE-----

allocateBuffer.patch (550 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: patch for allocateBuffer in AsyncFilePlugin

stes
 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Hello,

Can the allocateBuffer patch be added/committed to subversion, please ... ?

Thanks!

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJgVgepAAoJEAwpOKXMq1Ma4mMH/0vW0KPYBMtrvbeHl+9ec47x
6cIGQ/EHadOH6Ae2+sj96I2ArR9uHGXRPWVKa3Wf2G3NQwPMCUvKlqNCPfzZo8g9
4wYzjpvjrMuSgrnP7A9jCvYShQ/TZY7QwBWl83kbnW+7w4oLZxkXUIcOG6RhD71s
gXmNlFpx6xLTqe+Z1ljeR58/vh7TfxBE3lJy3arxY+apyyCw05BVeErn8zqCDMzx
KDnfJ7XrINJt0MubpfdvzFf4KvoPNwFSuT9MTqMOE0zxAqKLz5sCsFQfevhnZ3Qq
l4SRQhs5Mo01a+x4hCNT3yrHxgnJ8aGpWjxddW9wJ+3F0QTav9htAAb3wPBUCgk=
=+txC
-----END PGP SIGNATURE-----
Reply | Threaded
Open this post in threaded view
|

Re: patch for allocateBuffer in AsyncFilePlugin

David T. Lewis
 
On Sat, Mar 20, 2021 at 03:33:34PM +0100, [hidden email] wrote:

>
> Hello,
>
> Can the allocateBuffer patch be added/committed to subversion, please ... ?
>
> Thanks!
>
> Regards,
> David Stes
>

Done.

Thanks David