Hi Tobias,
yes I remember this message, thanks for the links.
My intention was to open a branch for fixing the issue and ask
permission before merging.
I'm pretty sure that the right thing would be to let the CI tell
whether we broke the MSVC/LLVM windows build or not.
That would be more efficient than requesting review from single person
for every single change.
Maybe someone can help Eliot setting this up.
Constantly red builds cannot sustainably scale anyway.
It would be great to integrate epoll fixes from David before they rot
for example.
Nicolas
Le mer. 21 avr. 2021 à 21:03, Tobias Pape <
[hidden email]> a écrit :
>
>
> Hai
>
>
> > On 21. Apr 2021, at 20:37, Nicolas Cellier <
[hidden email]> wrote:
> >
> >
> > Hi all,
> > may I suggest that we put a
> >
> > #ifdef HAVE_CONFIG_H
> > # include "config.h"
> > #endif
> >
> > ahead of a few strategic platforms (and src) files so as to rescue the
> > linux build?
> > Currently, the builds fail because of #error directive in config.h...
>
> I put it there because features.h depends on config.h
>
> > For some files that already include sqConfig.h, just moving sqConfig.h
> > ahead generally also solves the problem...
>
> I'm open to putting sqconfig.h back where it was,
> but it seems it broke the development of some windows features.
> It seems thats why
>
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/aafcb78371c7e576073a8dbf2f1f32667568e05e> exists, which moved the .h's around.
>
> So you should wait for Eliot before moving on here, as he explicitly asks:
> "I ask anyone wishing to alter the system here to please contact me and discuss
> before making changes. "
>
> Best regards
> -Tobias
>
> > I've tried it with some success...
>
>
Locked
