set equality has changed :-(

Hi Eliot,

On Mon, 18 Apr 2016, Eliot Miranda wrote:

Hi All,
    this used to work:

    (Set with: #module) = (IdentitySet with: #module)

when did this change and why?

I changed it in Collections-ul.669 last November, because it didn't work well. Let's see a different example:

| s i |
s := Set with: 'module' copy.
i := IdentitySet with: 'module' copy.
{
        s = i.
        i = s
}

The old implementation would return #(false true), while the new one evaluates to #(false false).

Levente

_,,,^..^,,,_
best, Eliot

On Mon, 18 Apr 2016, Eliot Miranda wrote:

On Mon, Apr 18, 2016 at 3:43 PM, Levente Uzonyi <[hidden email]> wrote:
      Hi Eliot,

      On Mon, 18 Apr 2016, Eliot Miranda wrote:

            Hi All,
                this used to work:

                (Set with: #module) = (IdentitySet with: #module)

            when did this change and why?


      I changed it in Collections-ul.669 last November, because it didn't work well. Let's see a different example:

      | s i |
      s := Set with: 'module' copy.
      i := IdentitySet with: 'module' copy.
      {
              s = i.
              i = s
      }

      The old implementation would return #(false true), while the new one evaluates to #(false false).


Right.  That's a pain, but fair enough.  This is clumsy: (aSet size = 1 and: [aSet anyOne = #module]).  This slightly less so:  aSet = (aSet
species with: #module).

You could also write it as

aSet asArray = #(module).

or as

(aSet as: Set) = (Set with: #module).

Levente

      Levente

            _,,,^..^,,,_
            best, Eliot


_,,,^..^,,,_
best, Eliot

On 19.04.2016, at 08:23, marcel.taeumel <[hidden email]> wrote:

> Hi Eliot,
>
> try this:
> (Set with: #module) includesAllOf: (IdentitySet with: #module).
>
> This is "hasEqualElements:" for all kinds of collections.

But this is not reflexive, right?

(Set withAll: #(module moep)) includesAllOf: (IdentitySet with: #module)

>
> Best,
> Marcel