spell/grammar correction for Preferences' help text

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

spell/grammar correction for Preferences' help text

espin
Hi all,
I wanted to commit to Inbox a version of Preferences' help text
(PreferenceBrowser class>>helpText) but when I found that the
changes compared to my image version (aligned with Trunk) were too big,
I decided to simply file the method out and attach it to this email.

I corrected some spelling and grammar mistakes:
goberned -> governed
<3rd person present tense verb> -> <3rd person present tense verb>+s

Should I have commited to Inbox even with all those changes?
What is the best practice here (or how is the Inbox aligned with Trunk)?

Hope it helps
Bye
Enrico

--
Enrico Spinielli
"Do Androids dream of electric sheep?"— Philip K. Dick
"Hear and forget; see and remember;do and understand."—Mitchel Resnick



PreferenceBrowser-helpText.st (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: spell/grammar correction for Preferences' help text

Bert Freudenberg
On 11.04.2010, at 14:04, Enrico Spinielli wrote:

> Hi all,
> I wanted to commit to Inbox a version of Preferences' help text
> (PreferenceBrowser class>>helpText) but when I found that the
> changes compared to my image version (aligned with Trunk) were too big,
> I decided to simply file the method out and attach it to this email.
>
> I corrected some spelling and grammar mistakes:
> goberned -> governed
> <3rd person present tense verb> -> <3rd person present tense verb>+s
>
> Should I have commited to Inbox even with all those changes?
> What is the best practice here (or how is the Inbox aligned with Trunk)?
>
> Hope it helps
> Bye
> Enrico

If you have private changes in a package you should not submit it to the trunk or inbox. This is unfortunately a serious shortcoming of Monticello, it does not support keeping changes for personal use separate from changes you want to submit to the public (except with mad override trickery).

One way is to "cherry pick" changes. Once you have saved your own version with all modifications (e.g. to the package cache) you can click "backport", choose a trunk version, and select only the changes you want to submit. MC will then revert to the trunk version you chose and apply the changes you selected. That version you can submit to the inbox. Then load your own version you saved in the package cache.

Another way is the one you did half of - just file out a changeset, then take a clean trunk image, file in your changeset, and submit that version to the inbox.

Btw, when I add a method for testing to a "system class" I put it in a category named "*bert". That way my additions do not interfere with the trunk packages.

- Bert -



Reply | Threaded
Open this post in threaded view
|

Re: spell/grammar correction for Preferences' help text

Casey Ransberger-2
In reply to this post by espin
I would have filed out the change, grabbed the most recent trunk image, updated from trunk, filed in the change, verified the change in the trunk image, and pushed to the inbox. 

The key here is that you don't need to commit from the same image you did your work in.

On Apr 11, 2010, at 5:04 AM, Enrico Spinielli <[hidden email]> wrote:

Hi all,
I wanted to commit to Inbox a version of Preferences' help text
(PreferenceBrowser class>>helpText) but when I found that the
changes compared to my image version (aligned with Trunk) were too big,
I decided to simply file the method out and attach it to this email.

I corrected some spelling and grammar mistakes:
goberned -> governed
<3rd person present tense verb> -> <3rd person present tense verb>+s

Should I have commited to Inbox even with all those changes?
What is the best practice here (or how is the Inbox aligned with Trunk)?

Hope it helps
Bye
Enrico

--
Enrico Spinielli
"Do Androids dream of electric sheep?"— Philip K. Dick
"Hear and forget; see and remember;do and understand."—Mitchel Resnick
<PreferenceBrowser-helpText.st>