Smalltalk › Squeak › Squeak VM

sqSCCSVersion.h not uptodate?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Nicolas Cellier

sqSCCSVersion.h not uptodate?

Hi all,

when I execute scripts/updateSCCSVersions I get two modified files

platforms/Cross/plugins/sqPluginsSCCSVersion.h

platforms/Cross/vm/sqSCCSVersion.h

is this expected?

should someone commit uptodate versions?

fniephaus

Re: sqSCCSVersion.h not uptodate?

On Tue, 25 Dec 2018 at 4:04 pm, Nicolas Cellier <[hidden email]> wrote:

Hi all,
when I execute scripts/updateSCCSVersions I get two modified files
platforms/Cross/plugins/sqPluginsSCCSVersion.h
platforms/Cross/vm/sqSCCSVersion.h

is this expected?
should someone commit uptodate versions?

Hi Nicolas,

Yes, I think it's supposed to be like that. updateSCCSVersions should automatically be invoked by Git and keeps the two files updated with the latest commit information. Why do you think these files are outdated?

Fabio

alistairgrant

Re: sqSCCSVersion.h not uptodate?

Hi Nicolas & Fabio,

On Tue, 25 Dec 2018 at 19:00, Fabio Niephaus <[hidden email]> wrote:

>
> On Tue, 25 Dec 2018 at 4:04 pm, Nicolas Cellier <[hidden email]> wrote:
>>
>>
>> Hi all,
>> when I execute scripts/updateSCCSVersions I get two modified files
>> platforms/Cross/plugins/sqPluginsSCCSVersion.h
>> platforms/Cross/vm/sqSCCSVersion.h
>>
>> is this expected?
>> should someone commit uptodate versions?
>
>
> Hi Nicolas,
>
> Yes, I think it's supposed to be like that. updateSCCSVersions should automatically be invoked by Git and keeps the two files updated with the latest commit information. Why do you think these files are outdated?

From memory:

scripts/updateSCCSVersions installs git hooks to automatically update
sqPluginsSCCSVersion.h & sqSCCSVersion.h with the current version
information whenever a commit is made (and also forces an update when
the script is run). The version information is reproducible, so there
isn't any need to commit the version files, which reduces the amount
of noise in the commit logs (otherwise these two files would form part
of *every* commit).

HTH,
Alistair

Nicolas Cellier

Re: sqSCCSVersion.h not uptodate?

Hi all,

thanks, I think I've understood what happened:

For some reasons, i've got a branch named HEAD!!!

scripts/updateSCCSVersion was applying hooks from this branch and thus was removing all the changes that happened in 2018,

https://github.com/OpenSmalltalk/opensmalltalk-vm/commits/Cog/platforms/Cross/vm/sqSCCSVersion.h

letting my working copy dirty...

I've eradicated the problem:

git branch -d HEAD

Now git status does not report any dirty (not staged) file when I run scripts/updateSCCSVersion

How the hell did I create this HEAD branch is another mistery, some miss-typing?

Are super powers of git for the best or for the worst?

It depends in which hands ;)

Most of what I do is thru SourceTree GUI, so I rarely mess directly with git command (I have to relearn them every time I need'em).

Le mar. 25 déc. 2018 à 19:38, Alistair Grant <[hidden email]> a écrit :

Hi Nicolas & Fabio,

On Tue, 25 Dec 2018 at 19:00, Fabio Niephaus <[hidden email]> wrote:
>
> On Tue, 25 Dec 2018 at 4:04 pm, Nicolas Cellier <[hidden email]> wrote:
>>
>>
>> Hi all,
>> when I execute scripts/updateSCCSVersions I get two modified files
>> platforms/Cross/plugins/sqPluginsSCCSVersion.h
>> platforms/Cross/vm/sqSCCSVersion.h
>>
>> is this expected?
>> should someone commit uptodate versions?
>
>
> Hi Nicolas,
>
> Yes, I think it's supposed to be like that. updateSCCSVersions should automatically be invoked by Git and keeps the two files updated with the latest commit information. Why do you think these files are outdated?

From memory:

scripts/updateSCCSVersions installs git hooks to automatically update
sqPluginsSCCSVersion.h & sqSCCSVersion.h with the current version
information whenever a commit is made (and also forces an update when
the script is run). The version information is reproducible, so there
isn't any need to commit the version files, which reduces the amount
of noise in the commit logs (otherwise these two files would form part
of *every* commit).

HTH,
Alistair