|
|
| [squeak-dev] [Bug] [Fix] Wish to have more fun looking at animated gifs from the web?
Hi Torsten,
Thanks for the quick feedback.
***
>Torsten Bergmann astares at gmx.de
>Fri Nov 14 10:30:57 UTC 2008
>
>Your changeset is not directly a patch for GIFReadWriter>>readBitData, it
>looks like you uploaded
>your (subclass) debug code with a class WizAnimGIfProbe including log stream
>stuff, ...
>However by patching the original method with the essential fix:
>
>initCodeSize := self next.
>bitMask := (1 bitShift: initCodeSize) - 1.
>
That is the essential fix.
I did indeed upload the wrong method. I have now corrected that.
I've also had a chance to look at the other gif you pointed out.
Examples of problem gifs are valuable. Thanx.
Analysis of the problem is in the report.
>Squeak correctly displays
>http://www.mathconsult.ch/showroom/unipoly/anim24.gif
>but not http://www.webdeveloper.com/animations/bnifiles/disco_anim_bf16.gif
Anim morph does not implement some of the expected graphic controls.
Only gifs that expect to replace the background between each image reproduce correctly.
Some gifs cleverly animate by adding their images successively.
Getting that to work in squeak will require a more major repair.
>
>BTW: since Squeak is able to display images when they are dragged from a
>browser onto
>the morphic world it would be nice to keep animated gifs animated after
>dragging.
Somebody mentioned that there is a preference for that. Somewhere.
So the fix is finding it and setting it.
[Steps on soapboxs. say:]
The best way to start a repair is to post a complaint on mantis.
Mantis is persistent and patient. A report serves as a nucleus and focus.
When fixed the report remains to document what has been done.
[Steps off soapbox. :) ]
Thanks again for your interest and help.
Yours in curiosity and service, --Jerome Peace
|
|
Locked
