[squeak-dev] Commit messages not appearing in list

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
cbc
Reply | Threaded
Open this post in threaded view
|

[squeak-dev] Commit messages not appearing in list

cbc
I've added 4 packages to the Inbox the last two days, and only one of
them showed up in the list (ironically, the retraction one because of
a bug).  The others did not show up at all.

The ones that are there include:
* A System package that includes a fix to MessageTally>>spyEvery:on:
to work with BlockClosures so that we can once again profile methods.
* A Collections package that includes a change to
Character>>digitValue that significantly speeds up the conversion of
Latin strings to numbers (and should still work fine for non-latin
digits).

-Chris

Reply | Threaded
Open this post in threaded view
|

Re: [squeak-dev] Commit messages not appearing in list

Ken Causey-3
Once again with feeling ( :) ):

> When you put a package version in the inbox and it generates the diff
> for the email and has no ancestor to compare against you get the
> entire package source listed and therefore a very large email.
> Squeak-dev logically blocks messages larger than 100KB, IIRC.

So SqueakSource will need some changes to make this use of a repository
(the Inbox) useful in terms of sending out notices.  Either

a) if the diff exceeds a certain size, send the message without the diff

b) check for ancestors within all projects, not just the current project

Choice b may be OK for source.squeak.org but unrealistic for
squeaksource.com.

Ken

On Thu, 2009-09-10 at 22:31 -0700, Chris Cunningham wrote:

> I've added 4 packages to the Inbox the last two days, and only one of
> them showed up in the list (ironically, the retraction one because of
> a bug).  The others did not show up at all.
>
> The ones that are there include:
> * A System package that includes a fix to MessageTally>>spyEvery:on:
> to work with BlockClosures so that we can once again profile methods.
> * A Collections package that includes a change to
> Character>>digitValue that significantly speeds up the conversion of
> Latin strings to numbers (and should still work fine for non-latin
> digits).
>
> -Chris
>
>



signature.asc (197 bytes) Download Attachment