[squeak-dev] [FIX] SMTPClient literal helo fix

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[squeak-dev] [FIX] SMTPClient literal helo fix

Greg A. Woods; Planix, Inc.
from preamble:

"Change Set: SMTPClient literal helo fix
Date: 4 December 2008
Author: Greg A. Woods

If Squeak is connecting to an SMTP server from a host with an IP address
that has no reverse DNS set up, such as is often the case for hosts on
private networks, especially wireless networks, then NetNameResolver
will return a string representation of the client's source IP address.
SMTPClient #initiateSession must send a HELO greeting with this IP
address in proper literal form, i.e. enclosed in square brackets,
instead of in the unadorned form it previously used.
"!

(I think it would be really nice if the diff between original and final
versions was also put in the text of the message in something like
normal unidiff form so that readers of the list don't have to directly
examine the change set itself inside a smalltalk image just to get an
overall view of what's being changed and how)



SMTPClient literal helo fix.cs.gz (894 bytes) Download Attachment