Smalltalk › Squeak › Squeak - Dev

[squeak-dev] Object>>launchPartVia:label:

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Casey Ransberger

[squeak-dev] Object>>launchPartVia:label:

Looking at this method, I don't really see why it needs to be on Object (feels like if it goes anywhere it should be on Morph.)

It has three senders in my trunk image, and one of them is mine:

IconicButton, PartsBin, and my own Pointy.

I decided to follow the rabbit down the hole and move the method from Object to Morph; after that the object palette and my own class (which uses IconicButtons to do more less what the object palette does) started saying the method wasn't found on Object's class side.

I sense metaprogramming, but I haven't figured out where it's happening. As an experiment, I moved the method over to the class side of Morph, and voila, everything works.

I am not sure if I'm doing something terribly wrong with this, so please apply with caution.

In the inbox:

Morphic-rss.173

Kernel-rss.245

Which would be applied in that order. If this actually works out for folks, I may also try moving #launchPartVia: out too.

--
Ron

Casey Ransberger

[squeak-dev] Re: Object>>launchPartVia:label:

Object>>launchPartVia: has no senders. I removed it. In the inbox:

Kernel-rss.246

On Mon, Sep 7, 2009 at 5:16 PM, Ronald Spengler <[hidden email]> wrote:

Looking at this method, I don't really see why it needs to be on Object (feels like if it goes anywhere it should be on Morph.)

It has three senders in my trunk image, and one of them is mine:

IconicButton, PartsBin, and my own Pointy.

I decided to follow the rabbit down the hole and move the method from Object to Morph; after that the object palette and my own class (which uses IconicButtons to do more less what the object palette does) started saying the method wasn't found on Object's class side.

I sense metaprogramming, but I haven't figured out where it's happening. As an experiment, I moved the method over to the class side of Morph, and voila, everything works.

I am not sure if I'm doing something terribly wrong with this, so please apply with caution.

In the inbox:

Morphic-rss.173
Kernel-rss.245

Which would be applied in that order. If this actually works out for folks, I may also try moving #launchPartVia: out too.

--
Ron

--
Ron

Bert Freudenberg

Re: [squeak-dev] Object>>launchPartVia:label:

In reply to this post by Casey Ransberger

On 08.09.2009, at 02:16, Ronald Spengler wrote:

> Looking at this method, I don't really see why it needs to be on
> Object (feels like if it goes anywhere it should be on Morph.)
>
> It has three senders in my trunk image, and one of them is mine:
>
> IconicButton, PartsBin, and my own Pointy.
>
> I decided to follow the rabbit down the hole and move the method
> from Object to Morph; after that the object palette and my own class
> (which uses IconicButtons to do more less what the object palette
> does) started saying the method wasn't found on Object's class side.
>
> I sense metaprogramming, but I haven't figured out where it's
> happening. As an experiment, I moved the method over to the class
> side of Morph, and voila, everything works.

Not quite everything I would guess. This method is used to launch any
object from a parts bin, e.g. the supplies/widgets/tools flaps and the
object catalog, not just morphs. It typically is sent to a class but
could very well be used with other objects too. So moving is seems
inappropriate.

- Bert -

> I am not sure if I'm doing something terribly wrong with this, so
> please apply with caution.
>
> In the inbox:
>
> Morphic-rss.173
> Kernel-rss.245
>
> Which would be applied in that order. If this actually works out for
> folks, I may also try moving #launchPartVia: out too.
>
> --
> Ron
>

Casey Ransberger

Re: [squeak-dev] Object>>launchPartVia:label:

Aha! Now I'm seeing what I misunderstood. Whoops. We should probably back out those two changes from the inbox.

Thanks Bert.

On Mon, Sep 7, 2009 at 5:47 PM, Bert Freudenberg <[hidden email]> wrote:

On 08.09.2009, at 02:16, Ronald Spengler wrote:

Looking at this method, I don't really see why it needs to be on Object (feels like if it goes anywhere it should be on Morph.)

It has three senders in my trunk image, and one of them is mine:

IconicButton, PartsBin, and my own Pointy.

I decided to follow the rabbit down the hole and move the method from Object to Morph; after that the object palette and my own class (which uses IconicButtons to do more less what the object palette does) started saying the method wasn't found on Object's class side.

I sense metaprogramming, but I haven't figured out where it's happening. As an experiment, I moved the method over to the class side of Morph, and voila, everything works.

Not quite everything I would guess. This method is used to launch any object from a parts bin, e.g. the supplies/widgets/tools flaps and the object catalog, not just morphs. It typically is sent to a class but could very well be used with other objects too. So moving is seems inappropriate.

- Bert -

I am not sure if I'm doing something terribly wrong with this, so please apply with caution.

In the inbox:

Morphic-rss.173
Kernel-rss.245

Which would be applied in that order. If this actually works out for folks, I may also try moving #launchPartVia: out too.

--
Ron

--
Ron

Casey Ransberger

Re: [squeak-dev] Object>>launchPartVia:label:

I was thinking that it only held Morphs. I see that I've broken some eToys scripting stuff and the tools. (As punishment for my poor testing, I took the liberty of dragging *everything* out of the object palette.) Thanks for catching my error, I'd hate to have broken the build.

Question: It looks as though launchPartVia: is a deprecated version of launchPartVia:label:. (I picture, someone needed a param aLabel, added it, did Cmd-S, added the param to all the places the message was sent, forgot to delete the original method.) Do we still need the unused method, is it used extensively by eToys?

On Mon, Sep 7, 2009 at 5:55 PM, Ronald Spengler <[hidden email]> wrote:

Aha! Now I'm seeing what I misunderstood. Whoops. We should probably back out those two changes from the inbox.

Thanks Bert.

On Mon, Sep 7, 2009 at 5:47 PM, Bert Freudenberg <[hidden email]> wrote:

On 08.09.2009, at 02:16, Ronald Spengler wrote:

Looking at this method, I don't really see why it needs to be on Object (feels like if it goes anywhere it should be on Morph.)

It has three senders in my trunk image, and one of them is mine:

IconicButton, PartsBin, and my own Pointy.

I decided to follow the rabbit down the hole and move the method from Object to Morph; after that the object palette and my own class (which uses IconicButtons to do more less what the object palette does) started saying the method wasn't found on Object's class side.

I sense metaprogramming, but I haven't figured out where it's happening. As an experiment, I moved the method over to the class side of Morph, and voila, everything works.

Not quite everything I would guess. This method is used to launch any object from a parts bin, e.g. the supplies/widgets/tools flaps and the object catalog, not just morphs. It typically is sent to a class but could very well be used with other objects too. So moving is seems inappropriate.

- Bert -

I am not sure if I'm doing something terribly wrong with this, so please apply with caution.

In the inbox:

Morphic-rss.173
Kernel-rss.245

Which would be applied in that order. If this actually works out for folks, I may also try moving #launchPartVia: out too.

--
Ron

--
Ron

--
Ron

Bert Freudenberg

Re: [squeak-dev] Object>>launchPartVia:label:

On 08.09.2009, at 03:34, Ronald Spengler wrote:

> I was thinking that it only held Morphs. I see that I've broken some
> eToys scripting stuff and the tools. (As punishment for my poor
> testing, I took the liberty of dragging *everything* out of the
> object palette.) Thanks for catching my error, I'd hate to have
> broken the build.
>
> Question: It looks as though launchPartVia: is a deprecated version
> of launchPartVia:label:. (I picture, someone needed a param aLabel,
> added it, did Cmd-S, added the param to all the places the message
> was sent, forgot to delete the original method.) Do we still need
> the unused method, is it used extensively by eToys?

It's unused as far as I can tell.

- Bert -