Smalltalk › Squeak › Squeak - Dev

[squeak-dev] Pango Plugin in latest Mac VM

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Yoshiki Ohshima-2

[squeak-dev] Pango Plugin in latest Mac VM

Hello,

I was informed by Edgar and Bert that there is some problem with
Pango plugin and latest Mac VM:

http://tunes.org/~nef/logs/squeak/09.07.07

I don't have Mac handy but by browsing the code,
primitivePangoIsAvailable may return Integer 2. I don't know why, but
it should return false at least. If you change it to false asOop:
Boolean does it change the behavior? If cairo is not installed it is
like to fail. Perhaps it should be pango_context_new() and then
pango_layout_new().

-- Yoshiki

johnmci

Re: [squeak-dev] Pango Plugin in latest Mac VM

Well that is because it return
2 if pango_cairo_create_layout fails
and your other choice is
true

never false because the code reads

_return_value = (1? interpreterProxy->trueObject(): interpreterProxy-
>falseObject());

Obviously someone needs to review primitivePangoIsAvailable

On 7-Jul-09, at 8:10 PM, Yoshiki Ohshima wrote:

> primitivePangoIsAvailable

--
=
=
=
========================================================================
John M. McIntosh <[hidden email]> Twitter:
squeaker68882
Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com
=
=
=
========================================================================

Yoshiki Ohshima-2

Re: [squeak-dev] Pango Plugin in latest Mac VM

At Tue, 7 Jul 2009 21:00:02 -0700,
John M McIntosh wrote:
>
> Well that is because it return
> 2 if pango_cairo_create_layout fails

That is "that" here?

My suggestion in the previous email was to change (2 asOop:
SmallInteger) to (false asOop: Boolean) and try it on Mac (without
Cairo installed). Could you try that?

And for the another part, I wondered if we can get a context with
ATSUI font and create a layout with it (pango_context_new() was a
wrong suggestion, though). But it looks like harder to maintain as a
single plugin.

-- Yoshiki

johnmci

Re: [squeak-dev] Pango Plugin in latest Mac VM

Well I can't seem to find a change set that has the
primitivePangoIsAvailable
It is in the unix src tree but I don't seem to have any smalltalk code
for it via 'http://source.impara.de/Rome'

So I'd guess the code is not in the mac plugin.

On 7-Jul-09, at 11:05 PM, Yoshiki Ohshima wrote:

> At Tue, 7 Jul 2009 21:00:02 -0700,
> John M McIntosh wrote:
>>
>> Well that is because it return
>> 2 if pango_cairo_create_layout fails
>
> That is "that" here?
>
> My suggestion in the previous email was to change (2 asOop:
> SmallInteger) to (false asOop: Boolean) and try it on Mac (without
> Cairo installed). Could you try that?
>
> And for the another part, I wondered if we can get a context with
> ATSUI font and create a layout with it (pango_context_new() was a
> wrong suggestion, though). But it looks like harder to maintain as a
> single plugin.
>
> -- Yoshiki
>

--
=
=
=
========================================================================
John M. McIntosh <[hidden email]> Twitter:
squeaker68882
Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com
=
=
=
========================================================================

Bert Freudenberg

Re: [squeak-dev] Pango Plugin in latest Mac VM

The impara repos are of historical interest only at this point. The
latest Rome plugin code is at

http://www.squeaksource.com/Rome.html

- Bert -

On 08.07.2009, at 08:58, John M McIntosh wrote:

> Well I can't seem to find a change set that has the
> primitivePangoIsAvailable
> It is in the unix src tree but I don't seem to have any smalltalk
> code for it via 'http://source.impara.de/Rome'
>
> So I'd guess the code is not in the mac plugin.
>
>
> On 7-Jul-09, at 11:05 PM, Yoshiki Ohshima wrote:
>
>> At Tue, 7 Jul 2009 21:00:02 -0700,
>> John M McIntosh wrote:
>>>
>>> Well that is because it return
>>> 2 if pango_cairo_create_layout fails
>>
>> That is "that" here?
>>
>> My suggestion in the previous email was to change (2 asOop:
>> SmallInteger) to (false asOop: Boolean) and try it on Mac (without
>> Cairo installed). Could you try that?
>>
>> And for the another part, I wondered if we can get a context with
>> ATSUI font and create a layout with it (pango_context_new() was a
>> wrong suggestion, though). But it looks like harder to maintain as a
>> single plugin.
>>
>> -- Yoshiki
>>
>
> --
> =
> =
> =
> =
> =
> ======================================================================
> John M. McIntosh <[hidden email]> Twitter:
> squeaker68882
> Corporate Smalltalk Consulting Ltd. http://
> www.smalltalkconsulting.com
> =
> =
> =
> =
> =
> ======================================================================
>
>
>
>
>