Smalltalk › Squeak › Squeak - Dev

[squeak-dev] SUnit broken again in squeak-dev images.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

11 messages Options

Bryce Kampjes

[squeak-dev] SUnit broken again in squeak-dev images.

This time it's the method:
TestCase class>>withInheritedSelectors

^ self shouldInheritSelectors ifTrue:
[ self allSelectorsBelow: TestCase ] ifFalse: [self selectors]

The method #allSelectorsBelow: isn't implemented in the image
so it's hard to see what this is supposed to do.

Bryce

Damien Cassou-3

Re: [squeak-dev] SUnit broken again in squeak-dev images.

On Tue, Mar 3, 2009 at 11:06 PM, <[hidden email]> wrote:
> This time it's the method:
> TestCase class>>withInheritedSelectors
>
> ^ self shouldInheritSelectors ifTrue:
> [ self allSelectorsBelow: TestCase ] ifFalse: [self selectors]
>
> The method #allSelectorsBelow: isn't implemented in the image
> so it's hard to see what this is supposed to do.

Sorry, it seems that SUnit depend on the following fix:

Installer upgrade.
Installer mantis bug: 7166 fix: 'Speedup-AllSelectors-M7166.1.cs'.

Does it work now?

--
Damien Cassou
http://damiencassou.seasidehosting.st

Bryce Kampjes

Re: [squeak-dev] SUnit broken again in squeak-dev images.

Damien Cassou writes:
> On Tue, Mar 3, 2009 at 11:06 PM, <[hidden email]> wrote:
> > This time it's the method:
> > TestCase class>>withInheritedSelectors
> >
> > ^ self shouldInheritSelectors ifTrue:
> > [ self allSelectorsBelow: TestCase ] ifFalse: [self selectors]
> >
> > The method #allSelectorsBelow: isn't implemented in the image
> > so it's hard to see what this is supposed to do.
>
> Sorry, it seems that SUnit depend on the following fix:
>
> Installer upgrade.
> Installer mantis bug: 7166 fix: 'Speedup-AllSelectors-M7166.1.cs'.
>
> Does it work now?

Thanks, that worked. This is going to be added to the squeak-dev
build scripts?

Bryce

Ken Causey-3

Re: [squeak-dev] SUnit broken again in squeak-dev images.

On Wed, 2009-03-04 at 20:20 +0000, [hidden email] wrote:

> Damien Cassou writes:
> > On Tue, Mar 3, 2009 at 11:06 PM, <[hidden email]> wrote:
> > > This time it's the method:
> > > TestCase class>>withInheritedSelectors
> > >
> > > ^ self shouldInheritSelectors ifTrue:
> > > [ self allSelectorsBelow: TestCase ] ifFalse: [self selectors]
> > >
> > > The method #allSelectorsBelow: isn't implemented in the image
> > > so it's hard to see what this is supposed to do.
> >
> > Sorry, it seems that SUnit depend on the following fix:
> >
> > Installer upgrade.
> > Installer mantis bug: 7166 fix: 'Speedup-AllSelectors-M7166.1.cs'.
> >
> > Does it work now?
>
> Thanks, that worked. This is going to be added to the squeak-dev
> build scripts?
>
> Bryce

It appears we need to repeat the guidelines for how fixes are
incorporated into 3.11. Better documentation suggestions are welcome.

It has been stated repeatedly now that for 3.11 Mantis will be used as
directly as possible for fix/enh including indicating how the build
system should treat issues. If you look at the report for this issue

http://bugs.squeak.org/view.php?id=7166

you will note that this is marked as being fixed for 3.10bc and it is
marked as Resolved. This should mean that it is shipped in the 3.10bc
(now called 3.10-build I think) images already.

Ken

signature.asc (196 bytes) Download Attachment

Damien Cassou-3

Re: [squeak-dev] SUnit broken again in squeak-dev images.

Hi Ken,

On Wed, Mar 4, 2009 at 10:39 PM, Ken Causey <[hidden email]> wrote:

> It appears we need to repeat the guidelines for how fixes are
> incorporated into 3.11. Better documentation suggestions are welcome.
>
> It has been stated repeatedly now that for 3.11 Mantis will be used as
> directly as possible for fix/enh including indicating how the build
> system should treat issues. If you look at the report for this issue
>
> http://bugs.squeak.org/view.php?id=7166
>
> you will note that this is marked as being fixed for 3.10bc and it is
> marked as Resolved. This should mean that it is shipped in the 3.10bc
> (now called 3.10-build I think) images already.

then I have different choices to build the future dev images:

- continue to ship a 3.10 version with or without the fix
- only ship 3.10.2-build images: that would mean anybody agree to have
LPF in his image

--
Damien Cassou
http://damiencassou.seasidehosting.st

Bryce Kampjes

Re: [squeak-dev] SUnit broken again in squeak-dev images.

Damien Cassou writes:
> Hi Ken,
>
> On Wed, Mar 4, 2009 at 10:39 PM, Ken Causey <[hidden email]> wrote:
> > It appears we need to repeat the guidelines for how fixes are
> > incorporated into 3.11. Better documentation suggestions are welcome.
> >
> > It has been stated repeatedly now that for 3.11 Mantis will be used as
> > directly as possible for fix/enh including indicating how the build
> > system should treat issues. If you look at the report for this issue
> >
> > http://bugs.squeak.org/view.php?id=7166
> >
> > you will note that this is marked as being fixed for 3.10bc and it is
> > marked as Resolved. This should mean that it is shipped in the 3.10bc
> > (now called 3.10-build I think) images already.
>
> then I have different choices to build the future dev images:
>
> - continue to ship a 3.10 version with or without the fix
> - only ship 3.10.2-build images: that would mean anybody agree to have
> LPF in his image

A third option would be to remove SUnit-improved as it doesn't
work in unpatched 3.10 images.

Bryce

keith1y

Re: [squeak-dev] SUnit broken again in squeak-dev images.

[hidden email] wrote:

> Damien Cassou writes:
> > Hi Ken,
> >
> > On Wed, Mar 4, 2009 at 10:39 PM, Ken Causey <[hidden email]> wrote:
> > > It appears we need to repeat the guidelines for how fixes are
> > > incorporated into 3.11. Better documentation suggestions are welcome.
> > >
> > > It has been stated repeatedly now that for 3.11 Mantis will be used as
> > > directly as possible for fix/enh including indicating how the build
> > > system should treat issues. If you look at the report for this issue
> > >
> > > http://bugs.squeak.org/view.php?id=7166
> > >
> > > you will note that this is marked as being fixed for 3.10bc and it is
> > > marked as Resolved. This should mean that it is shipped in the 3.10bc
> > > (now called 3.10-build I think) images already.
> >
> > then I have different choices to build the future dev images:
> >
> > - continue to ship a 3.10 version with or without the fix
> > - only ship 3.10.2-build images: that would mean anybody agree to have
> > LPF in his image
>
> A third option would be to remove SUnit-improved as it doesn't
> work in unpatched 3.10 images.
>
> Bryce
>

Forth option is to add the fix to Universes, it can be done

Keith

Damien Cassou-3

Re: [squeak-dev] SUnit broken again in squeak-dev images.

In reply to this post by Bryce Kampjes

On Thu, Mar 5, 2009 at 10:41 PM, <[hidden email]> wrote:
> A third option would be to remove SUnit-improved as it doesn't
> work in unpatched 3.10 images.

Since I'm not doing any Squeak programming anymore, I need you to
choose for me :-). Please tell me your preferred choice.

--
Damien Cassou
http://damiencassou.seasidehosting.st

Bryce Kampjes

Re: [squeak-dev] SUnit broken again in squeak-dev images.

Damien Cassou writes:
> On Thu, Mar 5, 2009 at 10:41 PM, <[hidden email]> wrote:
> > A third option would be to remove SUnit-improved as it doesn't
> > work in unpatched 3.10 images.
>
> Since I'm not doing any Squeak programming anymore, I need you to
> choose for me :-). Please tell me your preferred choice.

I don't mind, I only built that image with Squeak because Pharo
doesn't load Connectors. A slight preference to back out to plain
vanilla SUnit to avoid the need to apply any more patches if more
incompatible changes are made in SUnit-improved.

Bryce

Rob Rothwell

Re: [squeak-dev] SUnit broken again in squeak-dev images.

In reply to this post by Damien Cassou-3

On Fri, Mar 6, 2009 at 4:05 AM, Damien Cassou <[hidden email]> wrote:

On Thu, Mar 5, 2009 at 10:41 PM, <[hidden email]> wrote:
> A third option would be to remove SUnit-improved as it doesn't
> work in unpatched 3.10 images.

Since I'm not doing any Squeak programming anymore, I need you to
choose for me :-). Please tell me your preferred choice.

Off topic, but what are you doing then, and why do you keep building the dev images? :)

Rob

Damien Cassou-3

Re: [squeak-dev] SUnit broken again in squeak-dev images.

On Fri, Mar 6, 2009 at 11:45 PM, Rob Rothwell <[hidden email]> wrote:
> Off topic, but what are you doing then,

I'm doing a PhD in Java and uses Pharo when I have anything to develop :-).

> and why do you keep building the dev images? :)

Because people download them:
http://damiencassou.dabbledb.com/publish/dev-imagesdownloads

--
Damien Cassou
http://damiencassou.seasidehosting.st