[squeak-dev] The Trunk: System-rss.134.mcz

Andreas Raab uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-rss.134.mcz

==================== Summary ====================

Name: System-rss.134
Author: rss
Time: 23 August 2009, 1:16:51 am
UUID: 7fa112cd-50f3-417a-83de-6362827ff54e
Ancestors: System-rkrk.133

Removing cruft left over from colorPrint browser option and colorWhenPrettyPrinting preference.

=============== Diff against System-rkrk.133 ===============

Item was changed:
  ----- Method: SystemDictionary>>testFormatter2 (in category 'housekeeping') -----
  testFormatter2
  "Smalltalk testFormatter2"
 
  "Reformats the source for every method in the system, and
  then verifies that the order of source tokens is unchanged.
  The formatting used will be either classic monochrome or
  fancy polychrome, depending on the setting of the preference
  #colorWhenPrettyPrinting. "
+
+ "Note: removed references to Preferences colorWhenPrettyPrinting and replaced them simply with false, as I've been removing this preference lately. --Ron Spengler 8/23/09"
 
  | newCodeString badOnes n oldCodeString oldTokens newTokens |
  badOnes := OrderedCollection new.
  self forgetDoIts.
  'Formatting all classes...'
  displayProgressAt: Sensor cursorPoint
  from: 0
  to: CompiledMethod instanceCount
  during:
  [:bar |
  n := 0.
  self systemNavigation allBehaviorsDo:
  [:cls |
  "Transcript cr; show: cls name."
 
  cls selectors do:
  [:selector |
  (n := n + 1) \\ 100 = 0 ifTrue: [bar value: n].
  oldCodeString := (cls sourceCodeAt: selector) asString.
  newCodeString := cls prettyPrinterClass
  format: oldCodeString
  in: cls
  notifying: nil
+ decorated: false.
- decorated: Preferences colorWhenPrettyPrinting.
  oldTokens := oldCodeString findTokens: Character separators.
  newTokens := newCodeString findTokens: Character separators.
  oldTokens = newTokens
  ifFalse:
  [Transcript
  cr;
  show: '***' , cls name , ' ' , selector.
  badOnes add: cls name , ' ' , selector]]]].
  self systemNavigation browseMessageList: badOnes asSortedCollection
  name: 'Formatter Discrepancies'!

Item was changed:
  ----- Method: Preferences class>>defaultValueTableForCurrentRelease (in category 'misc') -----
  defaultValueTableForCurrentRelease
  "Answer a table defining default values for all the preferences in the release.  Returns a list of (pref-symbol, boolean-symbol) pairs"
 
  ^  #(
  (abbreviatedBrowserButtons false)
  (alternativeBrowseIt false)
  (annotationPanes false)
  (areaFillsAreTolerant false)
  (areaFillsAreVeryTolerant false)
  (automaticFlapLayout true)
  (automaticKeyGeneration false)
  (automaticPlatformSettings true)
  (automaticViewerPlacement true)
  (balloonHelpEnabled true)
  (balloonHelpInMessageLists false)
  (batchPenTrails false)
  (browseWithDragNDrop false)
  (browseWithPrettyPrint false)
  (browserShowsPackagePane false)
  (canRecordWhilePlaying false)
  (capitalizedReferences true)
  (caseSensitiveFinds false)
  (cautionBeforeClosing false)
  (changeSetVersionNumbers true)
  (checkForSlips true)
  (checkForUnsavedProjects true)
  (classicNavigatorEnabled false)
  (clickOnLabelToEdit false)
  (cmdDotEnabled true)
  (collapseWindowsInPlace false)
- (colorWhenPrettyPrinting false)
  (compactViewerFlaps false)
  (compressFlashImages false)
  (confirmFirstUseOfStyle true)
  (conversionMethodsAtFileOut false)
  (cpuWatcherEnabled false)
  (debugHaloHandle true)
  (debugPrintSpaceLog false)
  (debugShowDamage false)
  (decorateBrowserButtons true)
  (diffsInChangeList true)
  (diffsWithPrettyPrint false)
  (dismissAllOnOptionClose false)
  (dragNDropWithAnimation false)
  (eToyFriendly false)
  (eToyLoginEnabled false)
  (enableLocalSave true)
  (extractFlashInHighQuality true)
  (extractFlashInHighestQuality false)
  (fastDragWindowForMorphic true)
  (fenceEnabled true)
  (fullScreenLeavesDeskMargins true)
  (haloTransitions false)
  (hiddenScrollBars false)
  (higherPerformance false)
  (honorDesktopCmdKeys true)
  (ignoreStyleIfOnlyBold true)
  (includeSoundControlInNavigator false)
  (infiniteUndo false)
  (logDebuggerStackToFile true)
  (magicHalos false)
  (menuButtonInToolPane false)
  (menuColorFromWorld false)
  (menuKeyboardControl false)  
  (modalColorPickers true)
  (mouseOverForKeyboardFocus false)
  (mouseOverHalos false)
  (mvcProjectsAllowed true)
  (navigatorOnLeftEdge true)
  (noviceMode false)
  (okToReinitializeFlaps true)
  (optionalButtons true)
  (passwordsOnPublish false)
  (personalizedWorldMenu true)
  (postscriptStoredAsEPS false)
  (preserveTrash true)
  (projectViewsInWindows true)
  (projectZoom true)
  (projectsSentToDisk false)
  (promptForUpdateServer true)
  (propertySheetFromHalo false)
  (readDocumentAtStartup true)
  (restartAlsoProceeds false)
  (reverseWindowStagger true)
  (roundedMenuCorners true)
  (roundedWindowCorners true)
  (scrollBarsNarrow false)
  (scrollBarsOnRight true)
  (scrollBarsWithoutMenuButton false)
  (securityChecksEnabled false)
  (selectiveHalos false)
  (showBoundsInHalo false)
  (showDirectionForSketches false)
  (showDirectionHandles false)
  (showFlapsWhenPublishing false)
  (showProjectNavigator false)
  (showSecurityStatus true)
  (showSharedFlaps true)
  (signProjectFiles true)
  (simpleMenus false)
  (slideDismissalsToTrash true)
  (smartUpdating true)
  (soundQuickStart false)
  (soundStopWhenDone false)
  (soundsEnabled true)
  (startInUntrustedDirectory false)
  (systemWindowEmbedOK false)
  (thoroughSenders true)
  (tileTranslucentDrag true)
  (timeStampsInMenuTitles true)
  (turnOffPowerManager false)
  (twentyFourHourFileStamps true)
  (typeCheckingInTileScripting true)
  (uniTilesClassic true)
  (uniqueNamesInHalos false)
  (universalTiles false)
  (unlimitedPaintArea false)
  (updateSavesFile false)
  (useButtonProprtiesToFire false)
  (useUndo true)
  (viewersInFlaps true)
  (warnAboutInsecureContent true)
  (warnIfNoChangesFile true)
  (warnIfNoSourcesFile true))
 
 
  "
  Preferences defaultValueTableForCurrentRelease do:
  [:pair | (Preferences preferenceAt: pair first ifAbsent: [nil]) ifNotNilDo:
  [:pref | pref defaultValue: (pair last == true)]].
  Preferences chooseInitialSettings.
  "!

Item was changed:
  ----- Method: Preferences class>>smallLandPreferences (in category 'themes - small-land') -----
  smallLandPreferences
  "Private - change the preferences according to small-land taste"
 
  self setPreferencesFrom: #(
  (haloEnclosesFullBounds true)
  (showBoundsInHalo       true)
  (cmdGesturesEnabled false)
  (easySelection true)
  (abbreviatedBrowserButtons       true)
  (alternativeBrowseIt             true)
  (alwaysShowVScrollbar            false)
  (annotationPanes                 true)
  (balloonHelpInMessageLists       true)
  (browseWithDragNDrop             true)
  (browseWithPrettyPrint           true)
  (classicNewMorphMenu             true)
  (collapseWindowsInPlace          true)
- (colorWhenPrettyPrinting         true)
  (diffsWithPrettyPrint            true)
  (dragNDropWithAnimation          true)
  (duplicateControlAndAltKeys      true)
  (eToyFriendly                    true)
  (extraDebuggerButtons            true)
  (extractFlashInHighestQuality    true)
  (fastDragWindowForMorphic        false)
  (includeSoundControlInNavigator  true)
  (menuKeyboardControl             true)
  (menuAppearance3d false)
  (gradientMenu false)
  (mouseOverForKeyboardFocus       true)
  (optionalButtons                 true)
  (preserveTrash                   true)
  (projectViewsInWindows           true)
  (propertySheetFromHalo           true)
  (scrollBarsNarrow                true)
  (scrollBarsOnRight               true)
  (selectiveHalos                  true)
  (showDirectionForSketches        true)
  (showDirectionHandles            true)
  (slideDismissalsToTrash          true)
  (translationWithBabel            true)
  (unlimitedPaintArea              true)
  (unlimitedPaintArea              true)
 
  (menuColorFromWorld false)
  (noviceMode true)
  (uniqueNamesInHalos true)
  (infiniteUndo true)
  (useUndo true)
  (soundStopWhenDone true)
  ).
 
  self setParameter: #balloonHelpDelayTime to: 100.
  !

Item was changed:
  ----- Method: SystemDictionary>>testFormatter (in category 'housekeeping') -----
  testFormatter
  "Smalltalk testFormatter"
 
  "Reformats the source for every method in the system, and
  then compiles that source and verifies that it generates
  identical code. The formatting used will be either classic
  monochrome or fancy polychrome, depending on the setting
+ of the preference #colorWhenPrettyPrinting."
+
+ "Note: removed references to Preferences colorWhenPrettyPrinting and replaced them simply with false, as I've been removing this preference lately. --Ron Spengler 8/23/09"
- of the preference #colorWhenPrettyPrinting."
 
  | newCodeString methodNode oldMethod newMethod badOnes n |
  badOnes := OrderedCollection new.
  self forgetDoIts.
  'Formatting all classes...'
  displayProgressAt: Sensor cursorPoint
  from: 0
  to: CompiledMethod instanceCount
  during:
  [:bar |
  n := 0.
  self systemNavigation allBehaviorsDo:
  [:cls |
  "Transcript cr; show: cls name."
 
  cls selectors do:
  [:selector |
  (n := n + 1) \\ 100 = 0 ifTrue: [bar value: n].
  newCodeString := cls prettyPrinterClass
  format: (cls sourceCodeAt: selector)
  in: cls
  notifying: nil
+ decorated: false.
- decorated: Preferences colorWhenPrettyPrinting.
  methodNode := cls compilerClass new
  compile: newCodeString
  in: cls
  notifying: nil
  ifFail: [].
  newMethod := methodNode generate: #(0 0 0 0).
  oldMethod := cls compiledMethodAt: selector.
  oldMethod = newMethod
  ifFalse:
  [Transcript
  cr;
  show: '***' , cls name , ' ' , selector.
  badOnes add: cls name , ' ' , selector]]]].
  self systemNavigation browseMessageList: badOnes asSortedCollection
  name: 'Formatter Discrepancies'!

Item was removed:
- ----- Method: Preferences class>>colorWhenPrettyPrinting (in category 'standard queries') -----
- colorWhenPrettyPrinting
- ^ self
- valueOfFlag: #colorWhenPrettyPrinting
- ifAbsent: [false]!