[squeak-dev] The Trunk: ToolsTests-nice.1.mcz

Nicolas Cellier uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-nice.1.mcz

==================== Summary ====================

Name: ToolsTests-nice.1
Author: nice
Time: 24 August 2009, 10:45:58 am
UUID: d7b7c74c-656a-444b-baae-28784deca84f
Ancestors:

Create this package to categorize tests for
http://bugs.squeak.org/view.php?id=6812

This will not be uploaded automatically in the trunk images...
...until a mcm tells to do so if I understand it correctly.

==================== Snapshot ====================

SystemOrganization addCategory: #'ToolsTests-Inspector'!

TestCase subclass: #WeakSetInspectorTest
        instanceVariableNames: ''
        classVariableNames: ''
        poolDictionaries: ''
        category: 'ToolsTests-Inspector'!

----- Method: WeakSetInspectorTest>>testSymbolTableM6812 (in category 'testing') -----
testSymbolTableM6812
        "this test is related to http://bugs.squeak.org/view.php?id=6812"
       
        | aWeakSet anInspector fieldSize |
        aWeakSet := (Symbol classPool at: #SymbolTable).
        anInspector := (ToolSet inspectorClassOf: aWeakSet) inspect: aWeakSet.
       
        fieldSize := anInspector fieldList size.
        3 timesRepeat:
                [Smalltalk garbageCollect.
                self assert: fieldSize = anInspector fieldList size.]
        !

I thought we were going to use the tests repo for tests?

- Bert -

On Mon, 2009-08-24 at 23:02 +0200, Bert Freudenberg wrote: I thought the tests repo was simply an inbox for tests, in fact at one
point I advocated removing it.  Andreas had some argument against that
that I agreed with and can't remember just now.

In any case, I understood that for the time being, tests would live in
trunk along with the rest since we do continue to distribute them with
the image.  Also, during development I would want any developer that
updates his image to get the tests so when he runs the tests he is
getting the benefit of new tests.

Ken

I thought of the test repo as the inbox for tests and that these tests
should make it into the trunk like commits from the inbox, no? So if
someone could directly commit tests to the trunk he should do so?

Alex

On Mon, Aug 24, 2009 at 11:02 PM, Bert Freudenberg<[hidden email]> wrote:

On Mon, 2009-08-24 at 23:14 +0200, Alexander Lazarević wrote:
> I thought of the test repo as the inbox for tests and that these tests
> should make it into the trunk like commits from the inbox, no? So if
> someone could directly commit tests to the trunk he should do so?
>
> Alex

That's also my opinion.

Ken

Ken Causey wrote:
> I thought the tests repo was simply an inbox for tests, in fact at one
> point I advocated removing it.  Andreas had some argument against that
> that I agreed with and can't remember just now.

I don't recall either. And I think that whatever it was it wasn't right.
It is obviously causing issues already in such that we have
Tools-rkrk.113 in Tests (since it contains some tests for the browser)
and Tools-rkrk.114 (the actual code) in the Inbox. That is clearly not a
desirable situation because not only do we require people to commit code
twice that's being done in the same context, to different repositories,
we also require the integration work to be done twice in different
contexts (i.e., having Collection-foo.xyz inbox and
CollectionTests-foo.xyz in tests).

I'm in favor of merging all of the tests repository into the trunk and
then either delete the repository or remove access to it and put up a
notice that all contributions should go to the inbox.

Cheers,
   - Andreas

I commited in trunk.
The only problem is that I created a new category/package ToolsTests:
a new package won't load automatically.
I presume a mcm is needed...

Nicolas

2009/8/24 Ken Causey <[hidden email]>:

I completely agree. The tests and actual code should go together.  
Interesting how the process is shaping itself :-)

Robert


On Aug 25, 2009, at 6:37 AM, Andreas Raab wrote:

> Ken Causey wrote:
>> I thought the tests repo was simply an inbox for tests, in fact at  
>> one
>> point I advocated removing it.  Andreas had some argument against  
>> that
>> that I agreed with and can't remember just now.
>
> I don't recall either. And I think that whatever it was it wasn't  
> right. It is obviously causing issues already

On 25.08.2009, at 10:55, Robert Krahn wrote:


I moved all remaining versions from Tests to Inbox, and added a notice  
to Tests.

- Bert -

Apologies for the flurry of commit messages but I just cleaned out the
inbox with the test packages which are now all in the trunk. Hopefully
this will be a rare occasion. I've also updated the config map to
include both the VersionNumberTests as well as the ToolsTests packages.

Update and Enjoy!

Cheers,
   - Andreas

Bert Freudenberg wrote:

On Tue, 2009-08-25 at 14:28 +0200, Bert Freudenberg wrote: So is there some reason not to just go ahead and delete the Tests
project?  I'm inclined to do so.

Seems to me we are getting to the point where self-documentation is
becoming a necessity.  Perhaps http://www.squeak.org/development/ ?

Ken

On 25.08.2009, at 19:43, Ken Causey wrote:

I wasn't sure if anything points to it.

> Seems to me we are getting to the point where self-documentation is
> becoming a necessity.  Perhaps http://www.squeak.org/development/ ?

Sounds good :)

- Bert -