[squeak-dev] ivars in ChronologyConstants

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[squeak-dev] ivars in ChronologyConstants

Torsten Bergmann
I'm curious why the instance variables "seconds offset jdn nanos"
are left in the shared pool class "ChronologyConstants".

There is no accessor and the bindings are represented by class
variables anyway (as the comment in SharedPool states).

It's interesting that these instance variables are the same
as in DateAndTime class. Pharo looks the same.

When I remove all instance-vars in ChronologyConstants the
tests will still run - so can we remove them?

Anyone able to enlighten me?

Thx
T.

--
Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a

Reply | Threaded
Open this post in threaded view
|

Re: [squeak-dev] ivars in ChronologyConstants

Gary Chambers-4
Looks ok to remove...
Not that there should be any instances of ChronologyConstants around!

Regards, Gary

----- Original Message -----
From: "Torsten Bergmann" <[hidden email]>
To: <[hidden email]>
Sent: Wednesday, May 13, 2009 5:04 PM
Subject: [squeak-dev] ivars in ChronologyConstants


> I'm curious why the instance variables "seconds offset jdn nanos"
> are left in the shared pool class "ChronologyConstants".
>
> There is no accessor and the bindings are represented by class
> variables anyway (as the comment in SharedPool states).
>
> It's interesting that these instance variables are the same
> as in DateAndTime class. Pharo looks the same.
>
> When I remove all instance-vars in ChronologyConstants the
> tests will still run - so can we remove them?
>
> Anyone able to enlighten me?
>
> Thx
> T.
>
> --
> Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate +
> Telefonanschluss für nur 17,95 Euro/mtl.!*
> http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a
>


Reply | Threaded
Open this post in threaded view
|

[squeak-dev] Re: ivars in ChronologyConstants

Andreas.Raab
In reply to this post by Torsten Bergmann
Torsten Bergmann wrote:

> I'm curious why the instance variables "seconds offset jdn nanos"
> are left in the shared pool class "ChronologyConstants".
>
> There is no accessor and the bindings are represented by class
> variables anyway (as the comment in SharedPool states).
>
> It's interesting that these instance variables are the same
> as in DateAndTime class. Pharo looks the same.
>
> When I remove all instance-vars in ChronologyConstants the
> tests will still run - so can we remove them?
>
> Anyone able to enlighten me?

Pretty weird. It looks perfectly safe to remove those.

Cheers,
   - Andreas

Reply | Threaded
Open this post in threaded view
|

Re: [squeak-dev] Re: ivars in ChronologyConstants

Brent Pinkney-2
> > When I remove all instance-vars in ChronologyConstants the
> > tests will still run - so can we remove them?
> > Anyone able to enlighten me?

I wrote the Chronology package and have no idea how those ivars appeared.
They can be removed.