squeak.sh kernel check error

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

squeak.sh kernel check error

Ron Teitelbaum
Hi All,


This code 

  if [[ "${major}" -lt "${min_major}" ]] || \
     [[ "${major}" -le "${min_major}" && "${major}" -lt "${min_minor}" ]] || \
     [[ "${major}" -le "${min_major}" && "${major}" -le "${min_minor}" && "${patch}" -lt "${min_patch}" ]]; then
    showerror "Linux kernel ($(uname -r)) needs to be newer than ${min_major}.${min_minor}.${min_patch}."
    exit 1
  fi

Should be changed to:

  if [[ "${major}" -lt "${min_major}" ]] || \
     [[ "${major}" -le "${min_major}" && "${minor}" -lt "${min_minor}" ]] || \
     [[ "${major}" -le "${min_major}" && "${minor}" -le "${min_minor}" && "${patch}" -lt "${min_patch}" ]]; then
    showerror "Linux kernel ($(uname -r)) needs to be newer than ${min_major}.${min_minor}.${min_patch}."
    exit 1
  fi

All the best,

Ron Teitelbaum


Reply | Threaded
Open this post in threaded view
|

Re: squeak.sh kernel check error

fniephaus
Thanks, Ron. Just pushed your fix:

Linux bundle:
https://github.com/squeak-smalltalk/squeak-app/commit/d91ec77d5ff8901bd4155b88806def1840881272

AIO bundle:
https://github.com/squeak-smalltalk/squeak-app/commit/2541c1083bbda64a0839e3858f7517a493219de9

Cheers,
Fabio

On Mon, Mar 30, 2020 at 5:30 PM Ron Teitelbaum <[hidden email]> wrote:

>
> Hi All,
>
> The 64 bit linux version at: http://files.squeak.org/5.3/Squeak5.3-19431-64bit/Squeak5.3-19431-64bit-202003021730-Linux.zip squeak.sh has an error in it
>
> This code
>
>   if [[ "${major}" -lt "${min_major}" ]] || \
>      [[ "${major}" -le "${min_major}" && "${major}" -lt "${min_minor}" ]] || \
>      [[ "${major}" -le "${min_major}" && "${major}" -le "${min_minor}" && "${patch}" -lt "${min_patch}" ]]; then
>     showerror "Linux kernel ($(uname -r)) needs to be newer than ${min_major}.${min_minor}.${min_patch}."
>     exit 1
>   fi
>
> Should be changed to:
>
>   if [[ "${major}" -lt "${min_major}" ]] || \
>      [[ "${major}" -le "${min_major}" && "${minor}" -lt "${min_minor}" ]] || \
>      [[ "${major}" -le "${min_major}" && "${minor}" -le "${min_minor}" && "${patch}" -lt "${min_patch}" ]]; then
>     showerror "Linux kernel ($(uname -r)) needs to be newer than ${min_major}.${min_minor}.${min_patch}."
>     exit 1
>   fi
>
> All the best,
>
> Ron Teitelbaum
>

Reply | Threaded
Open this post in threaded view
|

Re: squeak.sh kernel check error

Ron Teitelbaum
Thanks Fabio!  

Ron

On Tue, Mar 31, 2020 at 12:30 PM Fabio Niephaus <[hidden email]> wrote:
Thanks, Ron. Just pushed your fix:

Linux bundle:
https://github.com/squeak-smalltalk/squeak-app/commit/d91ec77d5ff8901bd4155b88806def1840881272

AIO bundle:
https://github.com/squeak-smalltalk/squeak-app/commit/2541c1083bbda64a0839e3858f7517a493219de9

Cheers,
Fabio

On Mon, Mar 30, 2020 at 5:30 PM Ron Teitelbaum <[hidden email]> wrote:
>
> Hi All,
>
> The 64 bit linux version at: http://files.squeak.org/5.3/Squeak5.3-19431-64bit/Squeak5.3-19431-64bit-202003021730-Linux.zip squeak.sh has an error in it
>
> This code
>
>   if [[ "${major}" -lt "${min_major}" ]] || \
>      [[ "${major}" -le "${min_major}" && "${major}" -lt "${min_minor}" ]] || \
>      [[ "${major}" -le "${min_major}" && "${major}" -le "${min_minor}" && "${patch}" -lt "${min_patch}" ]]; then
>     showerror "Linux kernel ($(uname -r)) needs to be newer than ${min_major}.${min_minor}.${min_patch}."
>     exit 1
>   fi
>
> Should be changed to:
>
>   if [[ "${major}" -lt "${min_major}" ]] || \
>      [[ "${major}" -le "${min_major}" && "${minor}" -lt "${min_minor}" ]] || \
>      [[ "${major}" -le "${min_major}" && "${minor}" -le "${min_minor}" && "${patch}" -lt "${min_patch}" ]]; then
>     showerror "Linux kernel ($(uname -r)) needs to be newer than ${min_major}.${min_minor}.${min_patch}."
>     exit 1
>   fi
>
> All the best,
>
> Ron Teitelbaum
>