stepping in small panes

Hi Chris,

nice issue! I agree this would be an improvement in debugging scenarios.

However, when I press Shift + ArrowRight to extend the selection, I would indeed expect that the cursor is scrolled into view. I think we would need to distinguish between "machinal selection" and "selection by user."

And shouldn't we respect the selection orientation here (i.e., which of markIndex and pointIndex is larger - see TextEditor >> #exchange)?

Am 02.01.2020 23:58:37 schrieb Thiede, Christoph <[hidden email]>:

Great, I like this! Not sure how good style it is to use such dummy events, but the user experience is perfect :-)

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von Chris Muller <[hidden email]>
Gesendet: Donnerstag, 2. Januar 2020 22:59:08
An: The general-purpose Squeak developers list
Cc: [hidden email]
Betreff: Re: [squeak-dev] stepping in small panes

 

On Thu, Jan 2, 2020 at 2:19 PM Thiede, Christoph <[hidden email]> wrote:

Hi Chris,

nice issue! I agree this would be an improvement in debugging scenarios.

However, when I press Shift + ArrowRight to extend the selection, I would indeed expect that the cursor is scrolled into view.

Ah ha, THAT's why Marcel had that second call to #scrollToShow: in PluggableTextMorph>>#scrollSelectionIntoView:...   Nice catch!  I've just posted a fixed version, Morphic-cmm.1615.

I think we would need to distinguish between "machinal selection" and "selection by user."

Good idea!

And shouldn't we respect the selection orientation here (i.e., which of markIndex and pointIndex is larger - see TextEditor >> #exchange)?

I think so, but I'm not seeing where this is violated..  A little help please?   :)

 

But I would rather dislike a preference, imho we should make it dependent on the origin of the selection (machine vs. user) to achieve the best convenience.

Agree.

Thanks for the review,

  Chris

 

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von Chris Muller <[hidden email]>
Gesendet: Donnerstag, 2. Januar 2020 03:30:48
An: squeak dev
Betreff: [squeak-dev] stepping in small panes

 

Hi all,

When debugging on a small screen and a larger font, block expressions can easily overrun the size of the text pane.  Currently when stepping, selecting a stack frame, clicking Where -- anything that changes the text selection, it positions you to the bottom.

Unfortunately, this makes debugging cumbersome, because I need to see the beginning of the selection instead of the end, to know what I'm stepping through.

I use soft wrap, so don't face any issue along the horizontal dimension, but for the same principle, Morphic-cmm.1614 treats it similarly.

Before:

     VS   

What do you think?  Preference-worthy?

Best,

  Chris