sunos AppVeyor build succeeded and Travis CI build passed

 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



The "sunos" branch "pull request" attempt seems to have passed the

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

The build directories build.sunos32x86 and build.sunos64x64 were removed.

This is not much of a problem as they are now in a separate package,
"solaris-squeak" and this seems to work fine.

I just modified the "mvm" scripts (in the external package)
to set a "STDIR" (SmalltalkDirectory)
point to the opensmalltalk sources and then modified the "mvm" script to
look for the sources in the $STDIR directory.

Also the Pull Request indicates:

"This branch has no conflicts with the base branch
Only those with write access to this repository can merge pull requests."

So is it please possible to merge those fixes.

By the way for those who are afraid their version will stop working,
I can only say that "to err is human", I did my best not to break anything.

For example the "pulseaudio" is the default for me in the #ifdef __sun case,
but this case does not apply to other UNIX or Linux versions.

Also, regarding the "pulseaudio" change, (which was not changed so far
in the Cog branch!) be really unacceptable then I propose that the other
changes are merged, and that change not by whoever is merging the changes
...

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJeouxKAAoJEAwpOKXMq1MaOdkH/1BcvyOeFNiu3yJkvpnSH1i7
/j8Em+XO/JgMGFyvDNOW0TtSbem5pFXozEhR5U7enYp1IOkrjcA1uYxEYBeJ548R
KmWgTQj2dL/7ZEBiAdnYHE173/O0njStZDIA+/+bACWQN6I5J0ersx1aNH4zh9aN
65580kDbxjS/ubzY4XpYO8Y9TkKRe/F7mhFjyis5XMLELlWc+3eoX+c1bJT6ZxEH
cvGoah3A2CbtvHuyJjvTvApl6Bv1dUJYMIGFsiWfxEKCXemTY+ihb3gJ6hqbsziq
A2FiHSNRbnC3L3mZVltGAv/+OGZH9fPi2qj2buMVHMsO7Z/cVmn76r8SifCoImo=
=+6X9
-----END PGP SIGNATURE-----




--
Sent from: http://forum.world.st/Squeak-VM-f104410.html

 
Hi stes
> For example the "pulseaudio" is the default for me in the #ifdef __sun case,
> but this case does not apply to other UNIX or Linux versions.
>
> Also, regarding the "pulseaudio" change, (which was not changed so far
> in the Cog branch!) be really unacceptable then I propose that the other
> changes are merged, and that change not by whoever is merging the changes
> ...


First, thanks for caring for Solaris!

What my intention was, was to sort Unix-flavor specific things in platform/, for example, as you did with the pulse change.
Similar changes should go into, for example, the SSL-stuff as to have it always linked, never dynloaded.

then we can have a symlink sunos-whatever to linux-whatever.

Anyway, Thank you, and lets go ahead and see :)

Best regards
        -Tobias

 
Hi David,

I hope they get back.  I disagree with a Tobias and, as I thought had been agreed earlier, I want separate Solaris build directories.

If Tobias wants a single Unix build directory then he should follow the pattern in the minheadless builds, add a build.genericunix32 and build.genericunix64 and not abuse names but reinterpreting Linux to mean something different.

I shall try and get this done today.  

>
> By the way for those who are afraid their version will stop working,
> I can only say that "to err is human", I did my best not to break anything.

Don’t worry.  We all break things.  In return we must put in effort to fix things quickly.

>
> For example the "pulseaudio" is the default for me in the #ifdef __sun case,
> but this case does not apply to other UNIX or Linux versions.
>
> Also, regarding the "pulseaudio" change, (which was not changed so far
> in the Cog branch!) be really unacceptable then I propose that the other
> changes are merged, and that change not by whoever is merging the changes

It doesn’t seem unacceptable to me.

And I vote for you to be made a committer. How say everybody?

 
On Sat, Apr 25, 2020 at 07:31:22AM -0700, Eliot Miranda wrote:
>  
> Hi David,
>
> > On Apr 24, 2020, at 6:41 AM, stes <[hidden email]> wrote:
> >

<snip>

>
> And I vote for you to be made a committer. How say everybody?
>


+1

Dave

 
On 25/04/20 8:01 PM, Eliot Miranda wrote:
> And I vote for you to be made a committer. How say everybody?
+1