Re: No more dirty packages in Pharo
Posted by
Sean P. DeNigris on
Sep 26, 2013; 1:33pm
URL: https://forum.world.st/No-more-dirty-packages-in-Pharo-tp4705752p4710540.html
Tudor Girba-2 wrote
The only remaining problem was asMorph in Magritte-Morph, but I fixed it
now, so Magritte loads clean in Pharo 2.0.
Cool! That one's been bothering me for a while but I didn't feel confident to change it (I keep forgetting I seem to be the only one using Morphic ha ha).
Now that we're changing it, I had an idea a while back to make things clearer...
Adapted from
http://forum.world.st/Re-about-some-magritte-changes-I-made-td4257658.html#a4263576 :
1) #asMorph returns a presenter (MAXyzContainer), not a Morph. The current naming leads to "MyDomainObject asMorph morph", which doesn't make sense. #forMorphic, or #asMorphicContainer, or #asMorphicModel (since the container classes are all Model sublcasses) are more intention revealing.
2) Rename MAContainerMorph and friends -> MAMorphicContainer - these are not Morphs. I was actually astonished when I saw they did not inherit from Morph.
The Seaside part doesn't have this problem because an actual WAComponent is returned by #asComponent.
What do you think?
Cheers,
Sean