Login  Register

Re: The Trunk: GraphicsTests-dtl.43.mcz

Posted by David T. Lewis on Jun 18, 2017; 8:55pm
URL: https://forum.world.st/The-Trunk-GraphicsTests-dtl-43-mcz-tp4951835p4951842.html

On Sun, Jun 18, 2017 at 10:32:42PM +0200, Levente Uzonyi wrote:

> On Sun, 18 Jun 2017, [hidden email] wrote:
>
> >David T. Lewis uploaded a new version of GraphicsTests to project The
> >Trunk:
> >http://source.squeak.org/trunk/GraphicsTests-dtl.43.mcz
> >
> >==================== Summary ====================
> >
> >Name: GraphicsTests-dtl.43
> >Author: dtl
> >Time: 18 June 2017, 3:23:47.146706 pm
> >UUID: c6c174e4-6ce9-445c-aa4b-af5a52869461
> >Ancestors: GraphicsTests-pre.42
> >
> >Add PNGReadWriterTest>>testNewFromSampleBytes based on a problem report by
> >Hilaire Fernandes, and affecting Dr Geo. The test fails on 64 bit Spur if
> >a synthesized LargeInteger parameter to Bitmap #at:put: is not normalized
> >prior to calling the primitive.
> >
> >Problem reported at
> >http://lists.pharo.org/pipermail/pharo-users_lists.pharo.org/2017-June/032660.html
> >
> >=============== Diff against GraphicsTests-pre.42 ===============
> >
> >Item was added:
> >+ ----- Method: PNGReadWriterTest>>testNewFromSampleBytes (in category
> >'tests - decoding') -----
> >+ testNewFromSampleBytes
> >+ "Based on a problem report by Hilaire Fernandes, this fails on 64
> >bit Spur if a
> >+ synthesized LargeInteger parameter to Bitmap #at:put: is not
> >normalized prior
> >+ to calling the primitive. See problem report at
> >+  
> >http://lists.pharo.org/pipermail/pharo-users_lists.pharo.org/2017-June/032660.html"
> >+
> >+ | sampleBytes png form |
> >+ sampleBytes := #(137 80 78 71 13 10 26 10 0 0 0 13 73 72
>
> Why not a ByteArray literal instead of an Array converted to a ByteArray?
>

No good reason at all, I just copied it verbatim from Hilaire's problem report
on a Pharo mailing list, and I did not think of it.

Fixed, thanks.

Dave