Login  Register

Re: The Trunk: Kernel-nice.1389.mcz

Posted by Jakob Reschke on Apr 19, 2021; 7:11pm
URL: https://forum.world.st/The-Trunk-Kernel-nice-1389-mcz-tp5128770p5128897.html

Hi Nicolas,

Is there a particular reason why the handlers should not be reactivated in resumeUnchecked:?

I used resumeUnchecked: in a test case, which got broken. In this particular case I don't remember the necessity for resumeUnchecked: and could make the test green again by changing to plain resume:.

Kind regards,
Jakob

Am Fr., 16. Apr. 2021 um 21:42 Uhr schrieb <[hidden email]>:
Nicolas Cellier uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-nice.1389.mcz

==================== Summary ====================

Name: Kernel-nice.1389
Author: nice
Time: 16 April 2021, 9:42:34.176501 pm
UUID: 895e77fd-ce0e-484f-ad8a-00564ca98639
Ancestors: Kernel-nice.1388

Fix missing reactivation of handlers upon resume;

It is the responsibility of handling actions to rearm the handlers that have been disabled during the search of active handler.

=============== Diff against Kernel-nice.1388 ===============

Item was changed:
  ----- Method: Exception>>resume: (in category 'handling') -----
  resume: resumptionValue
        "Return resumptionValue as the value of the signal message."

        self isResumable ifFalse: [IllegalResumeAttempt signal].
+       self reactivateHandlers.
        self resumeUnchecked: resumptionValue!