Re: [ENH] isSeparator
Posted by
Levente Uzonyi on
May 07, 2021; 8:01pm
URL: https://forum.world.st/ENH-isSeparator-tp5129517p5129567.html
Hi Christoph,
There was a discussion on this subject before:
http://forum.world.st/The-Trunk-Collections-topa-806-mcz-td5084658.htmlMain concerns are
- definition: What is a separator?
- consistency: CharacterSet separators would differ from the rest with
your change set.
- performance: I haven't measured it, but I wouldn't be surprised if
#isSeparator would become a magnitude slower with that implementation.
Levente
On Thu, 6 May 2021,
[hidden email] wrote:
> Hi all,
>
> here is one tiny changeset for you: isSeparator.cs adds proper encoding-aware support for testing of separator chars. As opposed to the former implementation, non-ASCII characters such as the no-break space (U+00A0) will be identified correctly now, too.
>
> Please review and merge! :-)
>
> Best,
> Christoph
>
> ["isSeparator.cs.gz"]