Re: The Trunk: Morphic-mt.1769.mcz
Posted by Christoph Thiede on May 17, 2021; 10:49am
URL: https://forum.world.st/The-Trunk-Morphic-mt-1769-mcz-tp5129501p5129783.html
URL: https://forum.world.st/The-Trunk-Morphic-mt-1769-mcz-tp5129501p5129783.html
Nice catch! :-)
For anyone else wondering about this glitch:
Before:
After:
IMO our printing protocol on Number should have a padded argument similar to the (post-comma) decimal places.
Apart from that, I would have expected '-02' instead of '- 02'. :-)
Best,
Christoph
Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 6. Mai 2021 19:05:29
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: Morphic-mt.1769.mcz
Gesendet: Donnerstag, 6. Mai 2021 19:05:29
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: Morphic-mt.1769.mcz
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1769.mcz
==================== Summary ====================
Name: Morphic-mt.1769
Author: mt
Time: 6 May 2021, 7:05:24.828981 pm
UUID: 8109f744-f1f3-7048-8646-fed21a8e23d4
Ancestors: Morphic-ct.1768
Fixes minor glitch in objext explorers on integers.
This makes me wonder ... what are the expectations for negative integers here?
=============== Diff against Morphic-ct.1768 ===============
Item was changed:
----- Method: Integer>>explorerContents (in category '*Morphic-Explorer') -----
explorerContents
^#(
('hexadecimal' 16 2)
('octal' 8 3)
('binary' 2 4)) collect: [ :each | | label group |
group := each third.
+ label := self abs printStringBase: each second.
- label := self printStringBase: each second.
label := label padded: #left to: (label size roundUpTo: group) with: $0.
label := String streamContents: [:s |
+ self negative ifTrue: [s nextPutAll: '- '].
(1 to: label size by: group)
do: [:index |
1 to: group do: [:gIndex |
s nextPut: (label at: index + gIndex - 1)]]
separatedBy: [s space]].
ObjectExplorerWrapper
with: label
name: each first translated
model: self ]!
http://source.squeak.org/trunk/Morphic-mt.1769.mcz
==================== Summary ====================
Name: Morphic-mt.1769
Author: mt
Time: 6 May 2021, 7:05:24.828981 pm
UUID: 8109f744-f1f3-7048-8646-fed21a8e23d4
Ancestors: Morphic-ct.1768
Fixes minor glitch in objext explorers on integers.
This makes me wonder ... what are the expectations for negative integers here?
=============== Diff against Morphic-ct.1768 ===============
Item was changed:
----- Method: Integer>>explorerContents (in category '*Morphic-Explorer') -----
explorerContents
^#(
('hexadecimal' 16 2)
('octal' 8 3)
('binary' 2 4)) collect: [ :each | | label group |
group := each third.
+ label := self abs printStringBase: each second.
- label := self printStringBase: each second.
label := label padded: #left to: (label size roundUpTo: group) with: $0.
label := String streamContents: [:s |
+ self negative ifTrue: [s nextPutAll: '- '].
(1 to: label size by: group)
do: [:index |
1 to: group do: [:gIndex |
s nextPut: (label at: index + gIndex - 1)]]
separatedBy: [s space]].
ObjectExplorerWrapper
with: label
name: each first translated
model: self ]!
Carpe Squeak!
| Free forum by Nabble | Edit this page |