too much logging

Eliot, could this be the cause of Dave's "RemoteString" problem the other week?

Is this problem new to 4.5 or did it also exist in 4.4?

It's sounding more and more like we're going to need a 4.5.1.  So far we have:

  - Chinese character issue
  - Saving projects issue
  - 'Smalltalk' Environment issue
  - this?

2014-05-02 11:11 GMT-05:00 Eliot Miranda <[hidden email]>:

> Hi Colin, Hi All,
>
>     if in 4.5 one tries to evaluate a doit somewhere in a verdant
> transcript, one containing much content, then too much logging will occur to
> the changes file.  Instead of the selected doit being logged, the entire
> contents of the transcript up to the end of the doit will be logged, and
> that can cause parse errors when recovering changes.
>
> So how best to solve this?  Here are some ideas and I wanted to ask people's
> opinion
>
> - have CompilationCue remember the position of the source stream and instead
> of using "source contents" in streamToLog use "source position; upToEnd"
>
> - have Parser/Scanner remember the characters parsed in a buffer and take
> them from there
>
> - change ReadWriteStream to remember its initial position so that when one
> says
>     (ReadWriteStream on: (String withAll: ((0 to: 255) collect: [:n| n
> asCharacter]))
>         from: $A asInteger + 1 to: $Z asInteger + 1) contents
> one gets 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'
> instead of
>  '
> !"#$%&''()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ'
>
> IMO the last option is the right thing to do but it feels like a big change.
> --
> best,
> Eliot
>
>
>

Hi Colin, Hi All,

    if in 4.5 one tries to evaluate a doit somewhere in a verdant transcript, one containing much content, then too much logging will occur to the changes file.  Instead of the selected doit being logged, the entire contents of the transcript up to the end of the doit will be logged, and that can cause parse errors when recovering changes.

So how best to solve this?  Here are some ideas and I wanted to ask people's opinion

- have CompilationCue remember the position of the source stream and instead of using "source contents" in streamToLog use "source position; upToEnd"

- have Parser/Scanner remember the characters parsed in a buffer and take them from there

- change ReadWriteStream to remember its initial position so that when one says

    (ReadWriteStream on: (String withAll: ((0 to: 255) collect: [:n| n asCharacter]))

        from: $A asInteger + 1 to: $Z asInteger + 1) contents

one gets 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'

instead of

 '



!"#$%&''()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ'

IMO the last option is the right thing to do but it feels like a big change.