> On Sat, May 24, 2014 at 2:27 PM, Nicolas Cellier
> <
[hidden email]> wrote:
>>
>> Sorry to push such insignificant change (it's waiting a more serious
>> occasion in one of my images for 3 years),
>> but I wanted to trigger a build.squeak.org CI build...
>
>
> nothing to apologize for. (allSatisfy:) not. Really?? :-)
Nicolas didn't need to apologize, but I also think he expresses
totally the right attitude about making trivial improvements to code
in _general_. e.g., being conservative about it rather than
aggressive about it. (Eliot, I'm not saying you think otherwise --
nothing about you, in fact, nor any comment about (allSatisfy:) not.
This is just a general comment).
By trying to wait for a more significant change to be needed, Nicolas
shows the right level of consideration and respect for "treading on
others' code," and for the idea of having a rich change history, full
of _meaningful_ changes, instead of a bloated history dilute with
unmeaningful ones). Kudos Nicolas.
I see a lot of code that could be "improved", like factoring out
return carats for example, but I would never replace a "di 1998"
edition with "cmm 2014" only for that. I would not like anyone else
to do it only for that either.
If I feel strongly about a particular ugly code, I'll still look for
at least one additional "excuse" before committing a trivial change,
like Nicolas did today.