undo question

Hi Marcel, the new undo is great but I couldn't make it work across
cmd+l (cancelEdits) and cmd+s #accept, because it seems that the
'history' is discarded with the entire 'editor' by process of eagerly
calling #releaseEditor.  I know that was already there forever, but do
you know whether that is really necessary?  Those Editors could just
go away soon enough when the SystemWindow was closed, in the meantime,
the user having access to undo across saves and restores (as modern
text editors do) would be very useful.

No, I do not know, why the editor is released when accepting changes. However, it makes sense to purge the history of somebody exchanges all the text from the outside. The way it works now, it's quite robust. But there may be situations where we could retain the history such as this save operation.

Best,
Marcel

Hi.

What classes I should look to learn new undo implementation? And how it differs from old one?

It does not really differ from the old one.

TextEditor >> #openTypeIn (and senders)
TextEditor >> #closeTypeIn (and senders)
TextEditor >> #repalceSelectionWith: (and senders)

TextEditorCommand
TextEditorCommandHistory

Best,
Marcel

The current history is purged "more often" than the old one because the old one was stored in the text morph object and the new one is in the text editor object.

Best,
Marcel