Fix for OSProcess - Where to commit?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix for OSProcess - Where to commit?

marcel.taeumel (old)
Hi there! :)

I've got a fix for OS-Process. Where should I commit the code to? Squeaksource.com seems deprecated. However, I cannot find it on SmalltalkHub or ss3.gemstone... :-/

Best,
Marcel
Reply | Threaded
Open this post in threaded view
|

Re: Fix for OSProcess - Where to commit?

David T. Lewis
Hi Marcel,

On Thu, Nov 14, 2013 at 12:31:06AM -0800, Marcel Taeumel wrote:
> Hi there! :)
>
> I've got a fix for OS-Process. Where should I commit the code to?

The http://www.squeaksource.com/OSProcess repository is still the right
place. I can add you as a developer if you like, although I would really
prefer if you can send the update to me directly (and cc the list). The
reason is that I like to test across a range of Squeak and Pharo versions
before I commmit anything, and I also have managed to overcomplicate the
package structure in the repository to the point where it's easier if I
do it (the procedure is: apply patch, update OSProcess class>>versionString,
commit all affected sub-packages, then update the main OSProcess package).

> Squeaksource.com seems deprecated. However, I cannot find it on SmalltalkHub
> or ss3.gemstone... :-/
>

SqueakSource is alive and healthy, and I intend to keep my existing
projects on SqueakSource rather than migrate them to other repositories.
I have been personally involved in migrating squeaksource.com to its new
home at squeak.org, and my intention is to ensure that it is available
and operationally stable for the forseeable future.

The welcome (sic) message on the SqueakSource home page is overly alarming,
and IMHO should be changed to something that encourages new projects to
be created elsewhere, but that does not cause alarm for existing usurs.
But that is a policy decision, and I will defer to the Squeak board and
the Squeak community on this.

Thanks in advance for you contribution to OSProcess :-)

Dave


Reply | Threaded
Open this post in threaded view
|

Re: Fix for OSProcess - Where to commit?

Eliot Miranda-2
In reply to this post by marcel.taeumel (old)



On Thu, Nov 14, 2013 at 12:31 AM, Marcel Taeumel <[hidden email]> wrote:
Hi there! :)

I've got a fix for OS-Process. Where should I commit the code to?
Squeaksource.com seems deprecated. However, I cannot find it on SmalltalkHub
or ss3.gemstone... :-/

squeaksource.com is its home, e.g.

Name: OSProcess-dtl.85
Author: dtl
Time: 13 October 2013, 11:23:31.482 am
UUID: 2824c157-5d0e-4d3e-8f04-986d1f40b662
Ancestors: OSProcess-dtl.84
 

Best,
Marcel



--
View this message in context: http://forum.world.st/Fix-for-OSProcess-Where-to-commit-tp4721940.html
Sent from the Squeak - Dev mailing list archive at Nabble.com.




--
best,
Eliot


Reply | Threaded
Open this post in threaded view
|

Re: Fix for OSProcess - Where to commit?

marcel.taeumel (old)
In reply to this post by David T. Lewis
Hi Dave,

the fix is rather simple: #= is broken for ThisOSProcess, ExternalWindowsOSProcess, ExternalUnixOSProcess. The #isKindOf: check refers to self rather than to the argument as it should be. :) I use version 4.5.8.

Best,
Marcel

Reply | Threaded
Open this post in threaded view
|

Re: Fix for OSProcess - Where to commit?

David T. Lewis
On Fri, Nov 15, 2013 at 02:00:43AM -0800, Marcel Taeumel wrote:
> Hi Dave,
>
> the fix is rather simple: #= is broken for ThisOSProcess,
> ExternalWindowsOSProcess, ExternalUnixOSProcess. The #isKindOf: check refers
> to self rather than to the argument as it should be. :) I use version 4.5.8.

Hi Marcel,

Thanks very much! I have updated the OSProcess repository with your fix.

Dave