Issue 3583 in pharo: Shout should only be active in code panes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
83 messages Options
12345
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #20 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

There is no shouting, or the shouting is badly done ?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #21 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

In the Pharo 1.2 12324, there is no shouting either in the Debugger or in  
the Workspace.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #22 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

It should fix the debugger (and all the codeholders)

Let's take a look at the workspace now

Attachments:
        ShoutCodeHolder.1.cs  652 bytes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #23 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

That should shout the workspace :)


Give me feedback please ;)

Attachments:
        ShoutWorkspace.1.cs  547 bytes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #24 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Thanks a lot. I tested it briefly and it looks good.

It would be great to integrate this in 1.2.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #25 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

This is an important fix. Benjamin, could you create a slice?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #26 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I do know how to create a slice :$


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #27 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

i do NOT know (I'm tired ^^)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo
Updates:
        Cc: -guillermopolito -marcus.denker -stephane.ducasse Benjamin.VanRyseghem

Comment #28 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

See http://www.pharocasts.com/2010/03/how-to-contribute-to-pharo.html

In Monticello Browser (1.2) , click +Slice. Enter the issue number,  
copy/paste the issue title and select the packages to include, OK. Then  
select the slice in MB and save it to PharoInbox


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #29 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Thanks Laurent :)

Slice done:  
SLICE-Issue-3583-Shout-should-only-be-active-in-code-panes-BenjaminVanRyseghem.1  
in PharoInbox.

I hope it will work ;)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #30 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

ben your slice is empty. Could you republish it.
Or should I take the cs?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #31 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I tried to load the cses but they broke on me... unstyled or beStyled not  
found.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #32 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I have posted a new slide with the same name instead of two '-' at the  
beginning: SLICE-Issue-3583--Shout-should-only...

I've tested, it seams to work (I cross fingers).

If you want to use the cs, if you load the 4 cs in the good order, it  
should work (it's what I've fone to create the slice)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo
Updates:
        Status: Fixed

Comment #33 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I suggest that we stop changing code in the rc 1.2 else we will not succeed  
to release it.
So I will start to integrate this in 1.3 to see.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #34 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I understand the principle of releasing, but this small thing has a high  
impact. I suggest to still include this one in 1.2


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #35 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Ok but we should really stop.

In 13051


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #36 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

in 12334


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #37 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

When I load this slice into 1.2, workspace does not open anymore!!!
So doru if you want this fix in 1.2, help because I cannot spend time on it  
now.
The slice of ben worked well in 1.3 but probably 1.2 and 1.3 are diverging.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #38 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I'm trying a last time for today now.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3583 in pharo: Shout should only be active in code panes

pharo

Comment #39 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Since I have to cherrypick the changes and I do not know them... I will not  
do it using the slice.
I will try with the cs but it fails then somebody should provide us a slice  
loading only the changes in 1.2.


12345