Issue 3583 in pharo: Shout should only be active in code panes

Comment #40 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

When I try to load the cs in order I get an error.... if I drop the file  
and ask the code browser.
So I drop the file and loaded as new cs, so this means that we will have  
yet another bug in two versions....

So I sugges that we stop.

systemCategoryListIndex: anInteger
        "Set the selected system category index to be anInteger. Update all other
        selections to be deselected."

        self textMorph beStyled.

does not understand beStyled.

I integrated the change in 12334 and now if there is a bug. You should  
provide a fix and before try a lot of
behavior. This bug will not be a showstopper I imagine.

Updates:
        Status: Closed

Comment #41 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

(No comment was entered for this change.)

Comment #42 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Arghhhhhh
I could not release because workspace protocol changed between 1.2 and 1.3
So sorry guy but may be we will stay like that for now


edit: aText label: labelString accept: anAction
        "Open an editor on the given string/text"

        ^(Workspace openLabel: labelString)
                acceptContents:  aText;
                acceptAction: anAction;
                yourself.
       

Comment #43 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Hi Stef,

I just loaded the following slice in PharoDev based on 12331 and everything  
works just fine.

SLICE-Issue-3583--Shout-should-only-be-active-in-code-panes-BenjaminVanRyseghem.1

Comment #44 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I'll check that tomorrow ^^

Mmm, maybe it's not possible, but this issue is here because the merge between PluggableTextMorph and PluggableTextMorphWithShout was not completely done.  How difficult it is to go back to that refactor again and have this in mind?

Because this looks like a lot of patches and patches and patches...

Guille

Comment #45 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Doru I did that in 12333 and it did not.
Workspace did not work and too many changes that should not get in.
Did you really had a look at the changes?
We cannot change the system like that in 1.2rc1

Comment #46 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Here is what I see when I'm doing a merge and it cannot be. I cannot (and  
if I could I would not) integrate such a slice. Now if you succeed to  
produce a cs that I can load in 1.2 then ok but not this slice. This is why  
I tried to load the cs one by one but it barked. but at the end Workspace  
was broken.

Attachments:
        Screen shot 2011-02-10 at 10.51.13 PM.pdf  49.0 KB

Comment #47 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Mmm, maybe it's not possible, but this issue is here because the merge  
between PluggableTextMorph and PluggableTextMorphWithShout was not  
completely done or thought.  How difficult it is to go back to that  
refactor again and have this in mind?

Because this looks like a lot of patches and patches and patches...

Comment #48 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I do not understand ...

I just took the last 1.2 image from Hudson:
https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/132/

and load the slice, it works fine.
I've tried with the 4 cs, it works fine too ...

Strange

Comment #49 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Loading a slice does not mean that you only load what is needed. Here you  
load all the difference that have been changed between 12 and 13.
So have a look at it doing merge.

For the CS can you open a workspace after. I cannot.

Comment #50 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I've tried to do a merge, there is only one conflict, I choose to keep the  
current version, and it works fine ...

And the workspace two in both case ...

Comment #51 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

'too', not 'two' oO

Comment #52 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Thanks Benjamin for looking into this.

Updates:
        Status: Fixed

Comment #53 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Apparently in 1.3 there are places where texMorph is nil and it DNU when  
sent beStyled....
Fix attached now we shoudl defined two method in the Browser class instead  
of having this
self textMorph ifNotNilDo: [:it | it beStyled]

Attachments:
        beStyled.2.cs  7.8 KB

Comment #54 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Apparently in 1.3 there are places where texMorph is nil and it DNU when  
sent beStyled....
Fix attached now we shoudl defined two method in the Browser class instead  
of having this
self textMorph ifNotNilDo: [:it | it beStyled]

Attachments:
        beStyled.2.cs  7.8 KB

Comment #55 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Ok, I think I see where the confusion came from. If you load the slice of  
Benjamin in the Pharo 1.2, everything works fine. If you load it in  
**Pharo-Core** then it does not work.

So, I tracked a bit the errors in Pharo-Core. The reason the Workspace does  
not work is that apparently after the loading of the slice, somehow  
Workspace class does not understand open anymore. If I add this method,  
everything works fine.

The code browser works fine, but when trying to browse a class, we get an  
error because a textMorph is not initialized. I do not know why this  
happens.

Can anyone take a look and confirm?

Comment #56 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I've done a slice for 1.2 image (String Holder is now my friend ^^) in  
PharoInbox

And a little fix for 1.3 in order to consider SH preferences about styling

Attachments:
        FixPluggableTextMorph2.1.cs  264 bytes

Comment #57 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Ok we redid everything with Benjamin in 1.2

in 12335. Can you check that this is ok?

Updates:
        Status: Closed

Comment #58 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

We retroffit the 1.2 refactoring in StringHolder. Now 1.2 and 1.3 are in  
sync.
In 13055