Issue 3583 in pharo: Shout should only be active in code panes

Comment #59 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I checked the latest 1.2 build based on 12335. The Debugger works great,  
but the Workspace still does not offer highlighting.

Comment #60 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

this is strange because we tested the workspace.
but it should not be difficult to fix.

Comment #61 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

yes it's normal, for two reasons:
      - a method that should be removed is still here :s
      - SHWorkspace overrides a lot of methods and break the styling (ironic  
no ^^)

I've wrote a cs for the first point, and committed a new version of  
SHWorkspace emptied for the second.
I've also create a minimal cs that makes SHWorkspace work, but it's really  
a patch.

So with the last version of SHWorkspace, it should work now ^^
(maybe we should move SHWorkspace in Deprecated ?)


Attachments:
        FixWorkspaceAgain.1.cs  155 bytes
        FixSHWorkspace.1.cs  160 bytes

Comment #62 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Thanks a lot.
Now we should really update ConfigurationOfShout so that this version is  
for 1.2 and stay like that
and we can move on in 1.3.

Doru can you have a look at the configuration?

Updates:
        Status: Fixed

Comment #63 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

(No comment was entered for this change.)

Comment #64 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

As I understand, FixWorkspaceAgain.1.cs should be integrated in Pharo, and  
the latest version of SHWorkspace should work in both 1.2 and 1.3.

I tested it, but there still is a problem
- I type:
a := 1.
- a appears red because it's not defined yet.
- I do it.
- Whatever I do afterwards, a still appears like undefined.

Comment #65 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

In fact, without the FixWorkspaceAgain cs, shout (should) works in:
      - 1.2 core + Shout
      - 1.3 core + Shout
But not in 1.2 Dev due to SHWorkspace.
So now it should work in:
      - 1.2 core + Shout
      - 12. Dev
      - 1.3 Core
      - Probably 1.3 Dev too

For your problem, it happens in which image ? 1.2 core, 1.2 dev or 1.3  
core ?
I will check that, and try to fix it because it's time to finally close  
this entry ^^

Comment #66 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Thanks for the clarifications.

The problem I described happens in Pharo 1.2 (dev)

Comment #67 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I was wrong in the name of the cs.

What I said was about FixSHWorkspace.
FixWorkspaceAgain make shout works in 1.2 core + shout (a method was not  
removed as it should have been)

I take a look at your problem

Comment #68 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I trie din a 12335 with the two last cs (FixWorkspaceAgain and  
FixSHWorkspace)

I type

a := 1
here 'a'  appears in red, as expected.
Then above this line I add
| a |
this line is in grey, and a turn in grey too in the expression, as expected  
too :s

So either it works or I haven't understood what you've done ...
(see attachments for screenshots)

Attachments:
        Screen shot 2011-02-15 at 11.28.37 AM.png  14.2 KB
        Screen shot 2011-02-15 at 11.28.58 AM.png  14.4 KB

Comment #69 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

In the workspace variables are bound implicitly, and this should be taken  
into account during highlighting.

So, after evaluating a:=1, a will be bound and it should appear as such  
without declaring it.

Comment #70 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

I think it comes from the workspace, I'll take a look at the fix proposed  
to fix the declaration of new variables ...

Moreover, by default, the item "Automatically create temporary variables"  
is unselected (the square is blank), but variables created, and if you  
select it (the square is grayed), variables aren't created anymore ...

Comment #71 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Here two cs that fix this problem.
It's different in 1.2 and 1.3 because now Workspace superclass is Object :)

Here it works, so I cross fingers ^^

Attachments:
        FixWorkspace1.2.1.cs  567 bytes
        FixWorkspace1.3.1.cs  2.2 KB

Comment #72 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Some cs about refactorisation, and reactivating the style/unstyle item in  
the menu:

For 1.2 and 1.3:
       - PrepareFixWorkspaceMenu.2
       - FixWorkspaceMenu.1
For 1.2 Dev (to fix SHWorkspace):
       - FixSHWorkspaceToFixMenu.1

Attachments:
        PrepareFixWorkspaceMenu.2.cs  1.0 KB
        FixWorkspaceMenu.1.cs  10.0 KB
        FixSHWorkspaceToFixMenu.1.cs  349 bytes

Comment #73 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

A little sum up :)

 From a 1.2 Dev image 12335:
      - FixWorkspaceAgain.1
      - FixSHWorkspace.1
      - FixWorkspace1.2.1
      - PrepareFixWorkspaceMenu.2
      - FixWorkspaceMenu.1
      - FixSHWorkspaceToFixMenu.1

 From a 1.3 Core image 13055:
      - FixWorkspaceAgain.1
      - FixWorkspace1.3.1
      - PrepareFixWorkspaceMenu.2
      - FixWorkspaceMenu.1

Comment #74 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

OK doru do you integrate it in Shout?

Comment #75 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

What I've done about SHWorkspace is just a little patch. In fact this whole  
class can be emptied. If you want, I can take a look at the shout package,  
and remove useless things :)

But a better solution could be to change the list of tools pushed in a core  
image to create a Dev one and to remove all the SH tools (for 1.3)

Comment #76 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

yes we should finish 1.2 so minimizing the changes there

Comment #77 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Benjamin in 1.2 I cannot get it work :(
I check manually with textmate the changes and

- FixWorkspaceAgain.1
- FixWorkspace1.2.1
here it is working after
when I install PrepareFix (it was blocking) and wehn i restarted everything  
it was working-
so this is 'working' now when I load FIxWorkspaceMenu

when I press space I get a DNU every where in any pane.

styleInBackgroundProcess: aText
....
oldRuns withStartStopAndValueDo:[:start :stop :attribs|
                (attribs detect: [:each | each shoutShouldPreserve] ifNone:[nil]) == nil

So I'm lost again

Comment #78 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Yes, my bad, I forgot to remove a line after a copy/paste ...

Now it works in a 1.2 core, and it works well when I load shout ^^

Attachments:
        FixWorkspaceMenu.2.cs  9.8 KB