[OpenSmalltalk/opensmalltalk-v
Locked
[OpenSmalltalk/opensmalltalk-v
 
|
Two commits You can view, comment on, or merge this pull request online at:https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317 Commit Summary
File Changes
Patch Links:
— |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
I've rebased this away from my serial-fix-attempt onto the latest HEAD with Eliot's fix. — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
This is the same error I initially got on my local machine with last week's HEAD. Then I went back a few dozen commits and that Freetype build worked okay, then when I returned to the HEAD commit, it now worked. Huh!? — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
Hi Ben, Are you sure you didn't just go back to using the previous version of freetype (pre 2.9.1)? If you do have 2.9.1, do you know which commit you went back to? I'm still not able to build on windows :-( Thanks, — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
nope. freetype-2.9.1 also fails... $ ./mvm -d — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
I opened a new issue #319 for the freetype error introduced two weeks ago. — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
@nicolas-cellier-aka-nice commented on this pull request. In build.win32x86/pharo.stack.spur/Makefile: > @@ -0,0 +1,38 @@ +############################################################################# +# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin +# Do make init to allow make -n to function. +############################################################################# + +VM:=Pharo +VM_NAME:=Pharo Virtual Machine + +VMSRCDIR:=../../spurstacksrc/vm +# NOTES: +# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too). +# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, +# then FFI module needs to adjust that. It is NOT the case of mingw. +# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html +#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0 These comments are troubling... — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
@nicolas-cellier-aka-nice commented on this pull request. In build.win32x86/pharo.stack.spur/Makefile: > @@ -0,0 +1,38 @@ +############################################################################# +# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin +# Do make init to allow make -n to function. +############################################################################# + +VM:=Pharo +VM_NAME:=Pharo Virtual Machine + +VMSRCDIR:=../../spurstacksrc/vm +# NOTES: +# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too). +# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, +# then FFI module needs to adjust that. It is NOT the case of mingw. +# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html +#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0 Or maybe I just gave instructions in commit message e9ff2f2 ? — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
Hi Nicolas, the flags are necessary (but one is misnamed). See platforms/Cross/vm/sqCogStackAlignment.h for use and default definition of STACK_ALIGN_BYTES. See src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c for use of ALLOCA_LIES_SO_SETSP_BEFORE_CALL. But ALLOCA_LIES_SO_SETSP_BEFORE_CALL is set up by X64Win64FFIPlugin.c so we don't need it on the command line. — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
@bencoman commented on this pull request. In build.win32x86/pharo.stack.spur/Makefile: > @@ -0,0 +1,38 @@ +############################################################################# +# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin +# Do make init to allow make -n to function. +############################################################################# + +VM:=Pharo +VM_NAME:=Pharo Virtual Machine + +VMSRCDIR:=../../spurstacksrc/vm +# NOTES: +# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too). +# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, +# then FFI module needs to adjust that. It is NOT the case of mingw. +# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html +#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0 you are right, I just copied those lines from pharo.cog.spur. — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
@nicolas-cellier-aka-nice commented on this pull request. In build.win32x86/pharo.stack.spur/Makefile: > @@ -0,0 +1,38 @@ +############################################################################# +# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin +# Do make init to allow make -n to function. +############################################################################# + +VM:=Pharo +VM_NAME:=Pharo Virtual Machine + +VMSRCDIR:=../../spurstacksrc/vm +# NOTES: +# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too). +# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, +# then FFI module needs to adjust that. It is NOT the case of mingw. +# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html +#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0 Of course, changes can be post-poned after this PR. i just said "while at it" — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
I solved the freetype-2.9.1 build error in issue #319. It was an upstream problem unrelated to this PR. — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
Merged #317 into Cog. — |
| Free forum by Nabble | Edit this page |