[OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
49 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

codefrau
 
On Thu, Jul 9, 2020 at 6:52 AM David T. Lewis <[hidden email]> wrote:
 
On Thu, Jul 09, 2020 at 07:19:32AM +0200, Tobias Pape wrote:

> BTW: Fedora ships a 64bit squeak interpreter vm that can run 323bit closure  and non-closure images.
> Except for a broken Rome-plugin, this works very fine for Etoys 5.0???
>

That's interesting, I did not know about that. If you get a chance,
could you please check the version information for that VM? Either
the contents of a system reporter in the image, or from the command
line "/usr/bin/squeak -version" (assuming it is installed in /usr/bin).

At one time there was a Debian package for the interpreter VM, but
it was badly broken, so it would be nice to know if someone has been
distributing one that works.

Thank you!
Dave

I just found this site, which lists packages for many linux distros:


Fedora has 4.10.2.2614 VMs for 32 bit ARM, 64 bit ARM, and 64 bit x86, it appears.

This matches the last src.tar.gz on http://squeakvm.org/unix/release/

(IIRC it's an automated build that pulls the latest from that site - but I could be mixing that up with Debian)

That site also shows which distros carry etoys and scratch packages.

Vanessa
 
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

@LinqLover pushed 2 commits.

  • 1fde727 Add explaining comments
  • 33df20b Refactor drop event generation


You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/4def9a65347638fe002deb5cfb92d00fa532145c..33df20b6b4e18c5b827bd3da48be3ba0e1a1dcef", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/4def9a65347638fe002deb5cfb92d00fa532145c..33df20b6b4e18c5b827bd3da48be3ba0e1a1dcef", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

@LinqLover pushed 1 commit.


You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/33df20b6b4e18c5b827bd3da48be3ba0e1a1dcef..3100c64c6b770079bdd13888ed8740eff38a8fe7", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/33df20b6b4e18c5b827bd3da48be3ba0e1a1dcef..3100c64c6b770079bdd13888ed8740eff38a8fe7", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

@LinqLover pushed 1 commit.


You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/3100c64c6b770079bdd13888ed8740eff38a8fe7..2ff21e28c04f97b3250e8001a6befc33e21ca2b7", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/3100c64c6b770079bdd13888ed8740eff38a8fe7..2ff21e28c04f97b3250e8001a6befc33e21ca2b7", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

@LinqLover pushed 1 commit.


You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/2ff21e28c04f97b3250e8001a6befc33e21ca2b7..b992e979b0ddc8f0887e965f411d0a6ca5108282", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/2ff21e28c04f97b3250e8001a6befc33e21ca2b7..b992e979b0ddc8f0887e965f411d0a6ca5108282", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

Thanks for all the hints, I will try that soon! However, reviving the full DnD potential will surely happen in separate threads and PRs. This one is ready now, again, at least from my side. Please see the updated description above. I hereby confirm that the latest version again does not show any regressions in an up to date Squeak image. @nicolas-cellier-aka-nice Would you mind to review/squash-merge again as soon as the checks have completed? :-)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-656864568", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-656864568", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

@LinqLover pushed 1 commit.


You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/b992e979b0ddc8f0887e965f411d0a6ca5108282..403836b5d07d6036e2855d133d148df9e4602892", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508/files/b992e979b0ddc8f0887e965f411d0a6ca5108282..403836b5d07d6036e2855d133d148df9e4602892", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

I tested compiling this branch 'sqUnixXdnd' on Solaris;

the sqUnixXdnd code seems to compiles but how can I test please ?

In order to compile I have to apply a small patch, but that is always the case.
(see PR #496)

It is an interesting topic, to hear and read about the history of the
Unix VM and X11 support, which obviously is very much relevant to Solaris.

However when you write
"this does not show any regressions in an up to date Squeak image",

what exactly did you test please ?

Currently it seems I can drag a file into Squeak,
and this creates as PluggableSystemWindow object.

I don't seem to be able to drag anything out of Squeak.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfKYlWAAoJEAwpOKXMq1MapMEH/iHRtguF8NLJsLMeECjDq9WD
6jmpOJLSx3yNti9uc4dONaHSLLPCNO3QhbdLEAx5V9oHHjU9DVteIX5EWPNPMz5M
Rz0sO6uuKmdhptUzgIfxQCggm/C2hbVJZX4B72J6fGItpkyJTXUkl2tiwrKbFsZL
J2YUErvZo9NEo9bzhihI+uYGhMTieGeyfJ7jYLL1H6TwEkaA1A93S8L66DjrtOEh
Jg/nKkgcOAme9nSeaEjhOm/YazXdBeqej2e6uuD+8I4uVQ0BrdGivfDiMbKx8aOR
K12CYMHNTFg96K5ti9P62CgY5cyLwor3YOFSogjDXJZppp0Uy2o6yy3UnO4VCT8=
=CerU
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-668689833", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-668689833", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Actually on further inspection, there seems to exist a variable

if (getenv("SQUEAK_NOXDND")) useXdnd= 0;

when set , this disables the dnd support.

Indeed when export SQUEAK_NOXDND=1, the drag action of a file into Squeak,
is not doing anything.

But essentially I wonder (from the discussion) so far, what you are trying,
to change with this dnd PR and how I could try to test it.

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfKaSSAAoJEAwpOKXMq1MaC2QH/jIVUBRVOBBVqdF4tdpTxHUn
/H/quqS2MeD/MOTuV0UzWod41hNk9at//WiMM13mj4LAaWJyVcUFivLo4/68HUTe
IH3O3rC6RjztymoxD/kF6yT4nq7/Ay56706g1d/B9VPnl6Xk8z4bYuF4M1QvzG08
EwylFyc8tvxJiPs6TVmg0Hs/lx0Y2KPpdqnvlC3IC5U2dKI411rc4T4iWiQZix/U
IBbu+75gzTnOJlphNTPlRcesb6nEmqo57zfomBjW/GbUk28URtVoSnVmZZmvEUA2
4LZC2DpNdnZKA4dfdeQbBrvP7ndcHmSU6XjxAYTDWcKaCczj9/um4ChUbHQXnSs=
=y80j
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-668748316", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-668748316", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

Hi David,

thanks for your interest and sorry for the delay, I was on holiday!

what exactly did you test please ?

As you wrote, you can drag a file into the image and an external drop handler will handle it (or a dialog window will appear if there are multiple handlers). You can also drag multiple files into the image and they will be processed sequentially. So this is the only "acceptance test" I did so far.

From a lower-level perspective, you can manipulate HandMorph >> #generateDropFilesEvent: and insert a Transcript showln: {dragType. numFiles}. somewhere to watch the exact events generated by the VM. This PR removes duplicate/wrong events from the recorded list. You can also make sure that the following works:

  • drag a file over the image, but do not drop it, then drag it away - does the image still work?
  • after that, drag another file into the image and drop it - is the correct file displayed?
  • try to drag some text into the image - this attempt should be rejected but the image should still accept other files after that

But essentially I wonder (from the discussion) so far, what you are trying, to change with this dnd PR and how I could try to test it.

In the first step, I only cleaned up the list of DND events generated by the X11 OSVM as described in the PR message. Depending on this PR, I am extending #generateDropFilesEvent: to also process the DragMove and DragLeave events. This allows it not only to drag files into the world itself but wrap them into a Squeak-like TransferMorph that can be dropped into morph or tool by reusing the existing #acceptDroppingMorph: interface. For example, you can drop a file directly into the Workspace without any other modifications. Marcel's idea! :-)

I don't seem to be able to drag anything out of Squeak.

That's right, it might have worked on some platform in some ancient past, but nowadays it does not appear to work. But this would be interesting next steps, as well as dragging non-file stuff such as text or images into the image. Stay tuned! :-)

Best,
Christoph


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675442508", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675442508", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I tested the following, with a VM compiled from the sqUnixXdnd branch:

git remote -v

origin https://github.com/LinqLover/opensmalltalk-vm.git (fetch)
origin https://github.com/LinqLover/opensmalltalk-vm.git (push)

git branch

Cog

  • sqUnixXdnd

Tested:

  1. drag a file over the image, but do not drop it, then drag it away - does the image still work?

Yes it works , the cursor temporarily changes to a 'drag with +' sign when,
I drag the file1 over the VM display, and drag it away (without drop),
and the Squeak VM continues to function.

  1. after that, drag another file into the image and drop it - is the correct file displayed?

Yes, I think so. I have files file1 and file2 and first drag file1 without
drop, and then I drag file2, when I drop file2 it displays the file2 path.

  1. try to drag some text into the image - this attempt should be rejected but the image should still accept other files after that

The cursor changes again to a drag with "+" sign but when I drop the text,
which I drag out of an external text editor, nothing seems to happen in Squeak.

The image continues to accept other files after that.

What also seems to work for me is to drag a folder (directory) into Squeak.
I get some sort of Unix file browser for the files/directories in that folder
(in Squeak).

I think it is an interesting PR (pull request).

But basically I don't understand what you are trying to fix.

But obviously there must exist bugs in there ...

However basically you seem to be "cleaning up" while I don't understand
what effective bug you are trying to fix.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAlVAAoJEAwpOKXMq1MaFXkIAMA8YImzs9vBj7J68M3guJdS
+TfyKqjYaPJI6Vy+bcBeZxj9D2DlpqxG0AH/hRdccAFQ+iucql+ohJC4CeQ4CLT1
PlQjUfQO0XtShAkWCf1XP90PMbjaXZcnPfgCHCzC4XiDe09AVUeCSc0acwdg8JRe
ZGkcWt/r+HxRVvLyAr83JcNRyUQwei5U3pf5LS5v/QLv1WeqdKZJPLfTbYg+VDVZ
R0SZICNldynYBD1RInaiFiiwNknOI/CryAF8w/yj4zPV3trNDh3d54Yu1bgHdfj/
J05AD4vhGYNfUTzx+mn0Kz2vqb5k1RKWDgVX8yFJWI3cgqtTMjpcq0R0VBd7LFo=
=lLKy
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600340", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600340", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I tested the following, with a VM compiled from the sqUnixXdnd branch:

git remote -v

origin https://github.com/LinqLover/opensmalltalk-vm.git (fetch)
origin https://github.com/LinqLover/opensmalltalk-vm.git (push)

git branch

Cog

  • sqUnixXdnd

Tested:

  1. drag a file over the image, but do not drop it, then drag it away - does the image still work?

Yes it works , the cursor temporarily changes to a 'drag with +' sign when,
I drag the file1 over the VM display, and drag it away (without drop),
and the Squeak VM continues to function.

  1. after that, drag another file into the image and drop it - is the correct file displayed?

Yes, I think so. I have files file1 and file2 and first drag file1 without
drop, and then I drag file2, when I drop file2 it displays the file2 path.

  1. try to drag some text into the image - this attempt should be rejected but the image should still accept other files after that

The cursor changes again to a drag with "+" sign but when I drop the text,
which I drag out of an external text editor, nothing seems to happen in Squeak.

The image continues to accept other files after that.

What also seems to work for me is to drag a folder (directory) into Squeak.
I get some sort of Unix file browser for the files/directories in that folder
(in Squeak).

I think it is an interesting PR (pull request).

But basically I don't understand what you are trying to fix.

But obviously there must exist bugs in there ...

However basically you seem to be "cleaning up" while I don't understand
what effective bug you are trying to fix.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAlVAAoJEAwpOKXMq1MaFXkIAMA8YImzs9vBj7J68M3guJdS
+TfyKqjYaPJI6Vy+bcBeZxj9D2DlpqxG0AH/hRdccAFQ+iucql+ohJC4CeQ4CLT1
PlQjUfQO0XtShAkWCf1XP90PMbjaXZcnPfgCHCzC4XiDe09AVUeCSc0acwdg8JRe
ZGkcWt/r+HxRVvLyAr83JcNRyUQwei5U3pf5LS5v/QLv1WeqdKZJPLfTbYg+VDVZ
R0SZICNldynYBD1RInaiFiiwNknOI/CryAF8w/yj4zPV3trNDh3d54Yu1bgHdfj/
J05AD4vhGYNfUTzx+mn0Kz2vqb5k1RKWDgVX8yFJWI3cgqtTMjpcq0R0VBd7LFo=
=lLKy
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600442", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600442", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I tested the following, with a VM compiled from the sqUnixXdnd branch:

git remote -v

origin https://github.com/LinqLover/opensmalltalk-vm.git (fetch)
origin https://github.com/LinqLover/opensmalltalk-vm.git (push)

git branch

Cog

  • sqUnixXdnd

Tested:

  1. drag a file over the image, but do not drop it, then drag it away - does the image still work?

Yes it works , the cursor temporarily changes to a 'drag with +' sign when,
I drag the file1 over the VM display, and drag it away (without drop),
and the Squeak VM continues to function.

  1. after that, drag another file into the image and drop it - is the correct file displayed?

Yes, I think so. I have files file1 and file2 and first drag file1 without
drop, and then I drag file2, when I drop file2 it displays the file2 path.

  1. try to drag some text into the image - this attempt should be rejected but the image should still accept other files after that

The cursor changes again to a drag with "+" sign but when I drop the text,
which I drag out of an external text editor, nothing seems to happen in Squeak.

The image continues to accept other files after that.

What also seems to work for me is to drag a folder (directory) into Squeak.
I get some sort of Unix file browser for the files/directories in that folder
(in Squeak).

I think it is an interesting PR (pull request).

But basically I don't understand what you are trying to fix.

But obviously there must exist bugs in there ...

However basically you seem to be "cleaning up" while I don't understand
what effective bug you are trying to fix.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAlVAAoJEAwpOKXMq1MaFXkIAMA8YImzs9vBj7J68M3guJdS
+TfyKqjYaPJI6Vy+bcBeZxj9D2DlpqxG0AH/hRdccAFQ+iucql+ohJC4CeQ4CLT1
PlQjUfQO0XtShAkWCf1XP90PMbjaXZcnPfgCHCzC4XiDe09AVUeCSc0acwdg8JRe
ZGkcWt/r+HxRVvLyAr83JcNRyUQwei5U3pf5LS5v/QLv1WeqdKZJPLfTbYg+VDVZ
R0SZICNldynYBD1RInaiFiiwNknOI/CryAF8w/yj4zPV3trNDh3d54Yu1bgHdfj/
J05AD4vhGYNfUTzx+mn0Kz2vqb5k1RKWDgVX8yFJWI3cgqtTMjpcq0R0VBd7LFo=
=lLKy
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600441", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600441", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I tested the following, with a VM compiled from the sqUnixXdnd branch:

git remote -v

origin https://github.com/LinqLover/opensmalltalk-vm.git (fetch)
origin https://github.com/LinqLover/opensmalltalk-vm.git (push)

git branch

Cog

  • sqUnixXdnd

Tested:

  1. drag a file over the image, but do not drop it, then drag it away - does the image still work?

Yes it works , the cursor temporarily changes to a 'drag with +' sign when,
I drag the file1 over the VM display, and drag it away (without drop),
and the Squeak VM continues to function.

  1. after that, drag another file into the image and drop it - is the correct file displayed?

Yes, I think so. I have files file1 and file2 and first drag file1 without
drop, and then I drag file2, when I drop file2 it displays the file2 path.

  1. try to drag some text into the image - this attempt should be rejected but the image should still accept other files after that

The cursor changes again to a drag with "+" sign but when I drop the text,
which I drag out of an external text editor, nothing seems to happen in Squeak.

The image continues to accept other files after that.

What also seems to work for me is to drag a folder (directory) into Squeak.
I get some sort of Unix file browser for the files/directories in that folder
(in Squeak).

I think it is an interesting PR (pull request).

But basically I don't understand what you are trying to fix.

But obviously there must exist bugs in there ...

However basically you seem to be "cleaning up" while I don't understand
what effective bug you are trying to fix.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAlVAAoJEAwpOKXMq1MaFXkIAMA8YImzs9vBj7J68M3guJdS
+TfyKqjYaPJI6Vy+bcBeZxj9D2DlpqxG0AH/hRdccAFQ+iucql+ohJC4CeQ4CLT1
PlQjUfQO0XtShAkWCf1XP90PMbjaXZcnPfgCHCzC4XiDe09AVUeCSc0acwdg8JRe
ZGkcWt/r+HxRVvLyAr83JcNRyUQwei5U3pf5LS5v/QLv1WeqdKZJPLfTbYg+VDVZ
R0SZICNldynYBD1RInaiFiiwNknOI/CryAF8w/yj4zPV3trNDh3d54Yu1bgHdfj/
J05AD4vhGYNfUTzx+mn0Kz2vqb5k1RKWDgVX8yFJWI3cgqtTMjpcq0R0VBd7LFo=
=lLKy
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600519", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600519", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I tested the following, with a VM compiled from the sqUnixXdnd branch:

git remote -v

origin https://github.com/LinqLover/opensmalltalk-vm.git (fetch)
origin https://github.com/LinqLover/opensmalltalk-vm.git (push)

git branch

Cog

  • sqUnixXdnd

Tested:

  1. drag a file over the image, but do not drop it, then drag it away - does the image still work?

Yes it works , the cursor temporarily changes to a 'drag with +' sign when,
I drag the file1 over the VM display, and drag it away (without drop),
and the Squeak VM continues to function.

  1. after that, drag another file into the image and drop it - is the correct file displayed?

Yes, I think so. I have files file1 and file2 and first drag file1 without
drop, and then I drag file2, when I drop file2 it displays the file2 path.

  1. try to drag some text into the image - this attempt should be rejected but the image should still accept other files after that

The cursor changes again to a drag with "+" sign but when I drop the text,
which I drag out of an external text editor, nothing seems to happen in Squeak.

The image continues to accept other files after that.

What also seems to work for me is to drag a folder (directory) into Squeak.
I get some sort of Unix file browser for the files/directories in that folder
(in Squeak).

I think it is an interesting PR (pull request).

But basically I don't understand what you are trying to fix.

But obviously there must exist bugs in there ...

However basically you seem to be "cleaning up" while I don't understand
what effective bug you are trying to fix.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAlVAAoJEAwpOKXMq1MaFXkIAMA8YImzs9vBj7J68M3guJdS
+TfyKqjYaPJI6Vy+bcBeZxj9D2DlpqxG0AH/hRdccAFQ+iucql+ohJC4CeQ4CLT1
PlQjUfQO0XtShAkWCf1XP90PMbjaXZcnPfgCHCzC4XiDe09AVUeCSc0acwdg8JRe
ZGkcWt/r+HxRVvLyAr83JcNRyUQwei5U3pf5LS5v/QLv1WeqdKZJPLfTbYg+VDVZ
R0SZICNldynYBD1RInaiFiiwNknOI/CryAF8w/yj4zPV3trNDh3d54Yu1bgHdfj/
J05AD4vhGYNfUTzx+mn0Kz2vqb5k1RKWDgVX8yFJWI3cgqtTMjpcq0R0VBd7LFo=
=lLKy
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600518", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675600518", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

By the way I did the same 3 tests with a VM which I compiled from the
OpenSmalltalk Cog branch (not from the PR).

I seem to be having the same results.

David.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAwiAAoJEAwpOKXMq1MaE+4H/RIo+hfJjnwlvuMkSoRkkayi
uE2Qb/k8HnqKtH1Sz3r8xO77ciEcqctCqVzrpx5Z4iL0zhdQrpPHj5Ds7fBWU0lP
SHPlA/RffxhMXutZPwPk5K9roreuA96E5c6xAgCl1nT45LtyaQGZLbn7enzlK4xp
9aeGK4E1fxdnu93qj3zPGb8jrpnE5KlN1YMs9Q0Ynt+nW/gcftAsAGGX/32nTnvA
ipeSG5C8u9pdk3DCkdV8/LVrqlKWcWBnANEKcDw97Tr7zOlc4IIlFJAA1p2E+6Ns
rOIF0YKBKGVix9kI+lvssVM4TT/q5gsNpz4vKMrc3SGGAi8r/OHNpWLWBotBlC0=
=PSvQ
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675605340", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675605340", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

By the way I did the same 3 tests with a VM which I compiled from the
OpenSmalltalk Cog branch (not from the PR).

I seem to be having the same results.

David.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAwiAAoJEAwpOKXMq1MaE+4H/RIo+hfJjnwlvuMkSoRkkayi
uE2Qb/k8HnqKtH1Sz3r8xO77ciEcqctCqVzrpx5Z4iL0zhdQrpPHj5Ds7fBWU0lP
SHPlA/RffxhMXutZPwPk5K9roreuA96E5c6xAgCl1nT45LtyaQGZLbn7enzlK4xp
9aeGK4E1fxdnu93qj3zPGb8jrpnE5KlN1YMs9Q0Ynt+nW/gcftAsAGGX/32nTnvA
ipeSG5C8u9pdk3DCkdV8/LVrqlKWcWBnANEKcDw97Tr7zOlc4IIlFJAA1p2E+6Ns
rOIF0YKBKGVix9kI+lvssVM4TT/q5gsNpz4vKMrc3SGGAi8r/OHNpWLWBotBlC0=
=PSvQ
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675605753", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675605753", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

By the way I did the same 3 tests with a VM which I compiled from the
OpenSmalltalk Cog branch (not from the PR).

I seem to be having the same results.

David.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAwiAAoJEAwpOKXMq1MaE+4H/RIo+hfJjnwlvuMkSoRkkayi
uE2Qb/k8HnqKtH1Sz3r8xO77ciEcqctCqVzrpx5Z4iL0zhdQrpPHj5Ds7fBWU0lP
SHPlA/RffxhMXutZPwPk5K9roreuA96E5c6xAgCl1nT45LtyaQGZLbn7enzlK4xp
9aeGK4E1fxdnu93qj3zPGb8jrpnE5KlN1YMs9Q0Ynt+nW/gcftAsAGGX/32nTnvA
ipeSG5C8u9pdk3DCkdV8/LVrqlKWcWBnANEKcDw97Tr7zOlc4IIlFJAA1p2E+6Ns
rOIF0YKBKGVix9kI+lvssVM4TT/q5gsNpz4vKMrc3SGGAi8r/OHNpWLWBotBlC0=
=PSvQ
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675605756", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675605756", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

By the way I did the same 3 tests with a VM which I compiled from the
OpenSmalltalk Cog branch (not from the PR).

I seem to be having the same results.

David.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAwiAAoJEAwpOKXMq1MaE+4H/RIo+hfJjnwlvuMkSoRkkayi
uE2Qb/k8HnqKtH1Sz3r8xO77ciEcqctCqVzrpx5Z4iL0zhdQrpPHj5Ds7fBWU0lP
SHPlA/RffxhMXutZPwPk5K9roreuA96E5c6xAgCl1nT45LtyaQGZLbn7enzlK4xp
9aeGK4E1fxdnu93qj3zPGb8jrpnE5KlN1YMs9Q0Ynt+nW/gcftAsAGGX/32nTnvA
ipeSG5C8u9pdk3DCkdV8/LVrqlKWcWBnANEKcDw97Tr7zOlc4IIlFJAA1p2E+6Ns
rOIF0YKBKGVix9kI+lvssVM4TT/q5gsNpz4vKMrc3SGGAi8r/OHNpWLWBotBlC0=
=PSvQ
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675605759", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675605759", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

David T Lewis
In reply to this post by David T Lewis
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

By the way I did the same 3 tests with a VM which I compiled from the
OpenSmalltalk Cog branch (not from the PR).

I seem to be having the same results.

David.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPAwiAAoJEAwpOKXMq1MaE+4H/RIo+hfJjnwlvuMkSoRkkayi
uE2Qb/k8HnqKtH1Sz3r8xO77ciEcqctCqVzrpx5Z4iL0zhdQrpPHj5Ds7fBWU0lP
SHPlA/RffxhMXutZPwPk5K9roreuA96E5c6xAgCl1nT45LtyaQGZLbn7enzlK4xp
9aeGK4E1fxdnu93qj3zPGb8jrpnE5KlN1YMs9Q0Ynt+nW/gcftAsAGGX/32nTnvA
ipeSG5C8u9pdk3DCkdV8/LVrqlKWcWBnANEKcDw97Tr7zOlc4IIlFJAA1p2E+6Ns
rOIF0YKBKGVix9kI+lvssVM4TT/q5gsNpz4vKMrc3SGGAi8r/OHNpWLWBotBlC0=
=PSvQ
-----END PGP SIGNATURE-----


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675606014", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-675606014", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
123