[OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

 

Hi David,

thanks for sharing your observations, this fits in with my own results.

By the way I did the same 3 tests with a VM which I compiled from the OpenSmalltalk Cog branch (not from the PR).

I seem to be having the same results.

So there appears not to be any regression.

But basically I don't understand what you are trying to fix.

Here is how you can observe the erroneous under-the-hood behavior this PR aims to fix:

1. In a recent Squeak image, browse HandMorph >> #generateDropFilesEvent: and insert the following line after the assignment of dragType:

   Transcript showln: dragType.

2. Open a Transcript
3. Drag a file into the image

Transcript output on an X11 platform using the latest released plugin version:

1 (dragEnter)

2 (dragMove)

2 (dragMove)

...

2 (dragMove)

3 (dragLeave)

4 (dragDrop)

3 (dragLeave)

Transcript when compiling the plugin with the proposed patch applied:

1 (dragEnter)

2 (dragMove)

2 (dragMove)

...

2 (dragMove)

4 (dragDrop)

The current image implementation does not care about the additional, false dragLeave events, but my changeset which I am planning to put into the inbox will do so.

Is this comprehensible? 😅

PS: For some reasons all your posts arrive multiple times in the repository. Also, they would be easier to read if you could use codefences (```) :-)

Best,
Christoph

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676129131", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676129131", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

First of all, sorry if you receive this multiple times,
most likely this is because I click the "Comment" button multiple times.

OK, I modified the HandMorph -> private events -> generateDropFilesEvent:
as you indicated, from the Squeak6.0alpha-19793-64bit.image for the tests.

I also tried with Squeak 4,
I have the same result when I try with the Squeak4.6-15012 (Squeak 4 VM).

When I drag and drop a file "myfile" into the Squeak window,
the Transcript shows:

1
2
2
...
2
2
3
4
3

and the object for "myfile" is created.

If I drag "myfile" into the Squeak window and then out of it (without drop):

1
2
2
...
2
2
3

On the other hand if I use the VM, with this pull request, compiled :

First when drag and drop "myfile" :

1
2
2
...
2
2
4

Then when dragging "myfile" without drop :

1
2
2
...
2
2
3

So this confirms what you described ...

However to really test this pull request I think it is required to test
the code (changeset) which you are planning to put into the "inbox".

Maybe I missed something but in the description of this pull request,
you could give a pointer to the changeset you are developing.

Maybe if I can download it from some place, I can test it.

I now realise that you are actually talking about a combination of 2 things.

1. a change in the VM
2. a changeset of some Squeak code that depends on that the VM change

Correct ?

If so, I'd certainly would be interested in trying out the changeset.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPVl3AAoJEAwpOKXMq1MaVr8IAJLUPrZgBudoLM5GR7owR0/4
/vev7wuQvttCw3Sn1ib/G3podJywutiErXdugX3tA28hqyQvY9bFLzHK1+JjDyL1
ALhyg+uPzl+KOwtVEKBkAF2HO7dokDnr9eFIrSZyc917tb5IqnFW1yOBCdeVXqkn
JCCIi0nmU4psafmdEk8gVbQb4PdkNtdrgSck1GO1N2VyAkhiHyMNv+dJZs3ES2NZ
Id+t0+k3V1er5TJRnaOJj5vBluutMZqTD5yk4iZ1UGcR12wLgKGxENnFgLeIpPK0
WQI/0oHZUx8V5sP5id215U9bt/SkT8IXoDGQ54LC8Clv9JOjP6SkUH3K4j54Cs8=
=a1r+
-----END PGP SIGNATURE-----

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676543318", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676543318", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Thanks again for testing! :-)

I can share with you a working copy of my changeset, but it is still WIP. However, I am convinced that both changes in VM + image are decoupled enough and do not need to be released together. Even without any image change, I think that the old X11 event generation, saying "dragLeave dragDrop dragLeave" was erroneous by itself.

From my point of view, this PR is ready to merge as stated in July. :-)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676554176", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676554176", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I'm just commenting on this out of interest, I cannot say anything on
whether this PR is going to be merged, as I have nothing to do with that.

As far as I can see this looks a reasonable change, but we don't know,
how the original author(s) think about it, whether they had a reason for
their implementation.

But the context of your work is a little bit clearer now to me.

Basically you have dropFiles-examples.13.cs dropFiles3.14.cs changesets.

In my image I can "fileIn" those changesets by Tools->FileList and then
clicking "fileIn".

My understanding is now that you need some VM changes/support for the
dropFiles3.14.cs changeset, i.e. the underlying VM has some behavior,
that you want to change for the dropFiles changes.

If it's useful I can do further testing on this X11 platform,
as from what I understand this change is relevant to the Solaris X11 support.

For the moment - this may be a Solaris specific problem - when I test,
drag and drop after fileIn of the dropFiles changeset I get the following,
in a debugger:

• --- The full stack ---
  FileDirectory class>>requestDropDirectory:
  [] in HandMorph>>collectDropFilesAndDirectories:
  Interval>>collect:
  HandMorph>>collectDropFilesAndDirectories:
  HandMorph>>generateDropFilesEvent:
  HandMorph>>processEvents
  [] in WorldState>>doOneCycleNowFor:
  Array(SequenceableCollection)>>do:
  WorldState>>handsDo:
  WorldState>>doOneCycleNowFor:
  WorldState>>doOneCycleFor:
  PasteUpMorph>>doOneCycle
  [] in MorphicProject>>spawnNewProcess
  [] in FullBlockClosure(BlockClosure)>>newProcess

There may be Solaris specific issues with the FileDirectory I don't know.

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPkVcAAoJEAwpOKXMq1MaPcAH/R0nTxahFVzPv6abeDbA9gMh
GTKEXZBpQ/dEXCLedu1IVtUFnqqK2wdJJRt2HmhRZD3sxoT3YqnZfyJkip5A9mFt
+npBuMRsCAAu2suvmOpUMJQK6HTb9/hAJiAgNEDSnQ9RUFutIBo0+6MEONGj8vGF
WuJm31p9b8cAqLhi5twA3CcKC2P8PNkF+QS8RHDSO2SMJpEuGaTgxbCYkXJPEp15
o1cdZPqKcIlJGsf23B4V2XBWI38YxVOcMUS5CYzyACi8s/NnrCS5hNeAqzLX27QH
dLhTZipSvQlcwkS7sz1X1Xm5soVmNbVwZIhkUK4ydmWGiElgbl0ZkQgJtijgY7k=
=BNaM
-----END PGP SIGNATURE-----

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677495161", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677495161", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

David,

My understanding is now that you need some VM changes/support for the dropFiles3.14.cs changeset, i.e. the underlying VM has some behavior, that you want to change for the dropFiles changes.

Exactly.

For the moment - this may be a Solaris specific problem - when I test, drag and drop after fileIn of the dropFiles changeset I get the following, in a debugger:

This could be interesting. May I assume that the VM you used was compiled based on this PR? What is the exact error message you see?

I tested PR + changeset both in WSL + VcXsrv and a true Ubuntu VM and it worked fine for me. Maybe it's a Solaris problem, I don't know ...

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677553371", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677553371", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I compiled the VM from your repository branch "sqUnixXdnd"
(I applied one small patch the patch from PR #496 required on Solaris)

It's possible that there is some issue with the Solaris support,
as this has not been used for a long time I think,
and I'm only recently using it , but it's quite usable.

So when I use that VM and I use the Tools -> File List , I can "fileIn"
the changesets that you posted.

Then after that when I drag a file "myfile" into the Squeak desktop,
I get into a debugger.

When I right click on the debugger I can select "copy bug report to clipboard".

UndefinedObject(Object)>>error:
Receiver: nil
Arguments and temporary variables:
aString: 'Instances of UndefinedObject are not indexable'
Receiver's instance variables:
nil

UndefinedObject(Object)>>errorNotIndexable
Receiver: nil
Arguments and temporary variables:

Receiver's instance variables: 

nil

UndefinedObject(Object)>>size
Receiver: nil
Arguments and temporary variables:

Receiver's instance variables: 

nil

FileDirectory class>>on:
Receiver: FileDirectory
Arguments and temporary variables:
pathString: nil
pathName: nil
parentName: nil
Receiver's instance variables:
superclass: Object
methodDict: a MethodDictionary(size 125)
format: 65537
instanceVariables: #('pathName')
organization: ('enumeration' containingDirectory directoryEntries directoryEntry...etc...
subclasses: {UnixFileDirectory . AcornFileDirectory . MacFileDirectory . DosFileDirectory...etc...
name: #FileDirectory
classPool: a Dictionary(#DefaultDirectory->UnixFileDirectory on './stes/s...etc...
sharedPools: nil
environment: Smalltalk
category: #'Files-Directories'

FileDirectory class>>requestDropDirectory:
Receiver: FileDirectory
Arguments and temporary variables:
dropIndex: 1
potentialDirectory: nil
Receiver's instance variables:
superclass: Object
methodDict: a MethodDictionary(size 125)
format: 65537
instanceVariables: #('pathName')
organization: ('enumeration' containingDirectory directoryEntries directoryEntry...etc...
subclasses: {UnixFileDirectory . AcornFileDirectory . MacFileDirectory . DosFileDirectory...etc...
name: #FileDirectory
classPool: a Dictionary(#DefaultDirectory->UnixFileDirectory on './stes/s...etc...
sharedPools: nil
environment: Smalltalk
category: #'Files-Directories'

[] in HandMorph>>collectDropFilesAndDirectories:
Receiver: a HandMorph(1013123)
Arguments and temporary variables:
<
Receiver's instance variables:
bounds: 660@444 corner: 676@460
owner: a PasteUpMorph(2434915) [world]
submorphs: #()
fullBounds: 660@444 corner: 676@460
color: Color blue
extension: a MorphExtension (1604074) [eventHandler = an EventHandler] [other:...etc...
mouseFocus: nil
keyboardFocus: a TextMorphForEditView(3274035)
eventListeners: nil
mouseListeners: nil
keyboardListeners: nil
eventCaptureFilters: nil
mouseCaptureFilters: nil
keyboardCaptureFilters: a WeakArray(a HandMorph(1013123))
mouseClickState: nil
mouseOverHandler: a MouseOverHandler
targetOffset: 68@9
lastMouseEvent: [660@444 mouseUp ( red ) 111157]
damageRecorder: a DamageRecorder
cacheCanvas: nil
cachedCanvasHasHoles: true
temporaryCursor: nil
temporaryCursorOffset: nil
hardwareCursor: nil
hasChanged: true
savedPatch: nil
userInitials: ''
lastEventBuffer: #(1 111157 660 444 0 0 0 1)
genieGestureProcessor: nil
keyboardInterpreter: an UTF32InputInterpreter
externalDropMorph: nil

Interval>>collect:
Receiver: (1 to: 1)
Arguments and temporary variables:
aBlock: [closure] in HandMorph>>collectDropFilesAndDirectories:
nextValue: 1
result: #(nil)
i: 1
iLimiT: 1
Receiver's instance variables:
start: 1
stop: 1
step: 1

HandMorph>>collectDropFilesAndDirectories:
Receiver: a HandMorph(1013123)
Arguments and temporary variables:
numFiles: 1
Receiver's instance variables:
bounds: 660@444 corner: 676@460
owner: a PasteUpMorph(2434915) [world]
submorphs: #()
fullBounds: 660@444 corner: 676@460
color: Color blue
extension: a MorphExtension (1604074) [eventHandler = an EventHandler] [other:...etc...
mouseFocus: nil
keyboardFocus: a TextMorphForEditView(3274035)
eventListeners: nil
mouseListeners: nil
keyboardListeners: nil
eventCaptureFilters: nil
mouseCaptureFilters: nil
keyboardCaptureFilters: a WeakArray(a HandMorph(1013123))
mouseClickState: nil
mouseOverHandler: a MouseOverHandler
targetOffset: 68@9
lastMouseEvent: [660@444 mouseUp ( red ) 111157]
damageRecorder: a DamageRecorder
cacheCanvas: nil
cachedCanvasHasHoles: true
temporaryCursor: nil
temporaryCursorOffset: nil
hardwareCursor: nil
hasChanged: true
savedPatch: nil
userInitials: ''
lastEventBuffer: #(1 111157 660 444 0 0 0 1)
genieGestureProcessor: nil
keyboardInterpreter: an UTF32InputInterpreter
externalDropMorph: nil

HandMorph>>generateDropFilesEvent:
Receiver: a HandMorph(1013123)
Arguments and temporary variables:
evtBuf: #(3 58791 1 803 1 0 1 1)
position: 803@1
buttons: 1
modifiers: 0
stamp: 58791
numFiles: 1
dragType: 1
filesAndDirectories: nil
oldButtons: nil
Receiver's instance variables:
bounds: 660@444 corner: 676@460
owner: a PasteUpMorph(2434915) [world]
submorphs: #()
fullBounds: 660@444 corner: 676@460
color: Color blue
extension: a MorphExtension (1604074) [eventHandler = an EventHandler] [other:...etc...
mouseFocus: nil
keyboardFocus: a TextMorphForEditView(3274035)
eventListeners: nil
mouseListeners: nil
keyboardListeners: nil
eventCaptureFilters: nil
mouseCaptureFilters: nil
keyboardCaptureFilters: a WeakArray(a HandMorph(1013123))
mouseClickState: nil
mouseOverHandler: a MouseOverHandler
targetOffset: 68@9
lastMouseEvent: [660@444 mouseUp ( red ) 111157]
damageRecorder: a DamageRecorder
cacheCanvas: nil
cachedCanvasHasHoles: true
temporaryCursor: nil
temporaryCursorOffset: nil
hardwareCursor: nil
hasChanged: true
savedPatch: nil
userInitials: ''
lastEventBuffer: #(1 111157 660 444 0 0 0 1)
genieGestureProcessor: nil
keyboardInterpreter: an UTF32InputInterpreter
externalDropMorph: nil

HandMorph>>processEvents
Receiver: a HandMorph(1013123)
Arguments and temporary variables:
evt: nil
evtBuf: #(3 58791 1 803 1 0 1 1)
type: 3
hadAny: false
Receiver's instance variables:
bounds: 660@444 corner: 676@460
owner: a PasteUpMorph(2434915) [world]
submorphs: #()
fullBounds: 660@444 corner: 676@460
color: Color blue
extension: a MorphExtension (1604074) [eventHandler = an EventHandler] [other:...etc...
mouseFocus: nil
keyboardFocus: a TextMorphForEditView(3274035)
eventListeners: nil
mouseListeners: nil
keyboardListeners: nil
eventCaptureFilters: nil
mouseCaptureFilters: nil
keyboardCaptureFilters: a WeakArray(a HandMorph(1013123))
mouseClickState: nil
mouseOverHandler: a MouseOverHandler
targetOffset: 68@9
lastMouseEvent: [660@444 mouseUp ( red ) 111157]
damageRecorder: a DamageRecorder
cacheCanvas: nil
cachedCanvasHasHoles: true
temporaryCursor: nil
temporaryCursorOffset: nil
hardwareCursor: nil
hasChanged: true
savedPatch: nil
userInitials: ''
lastEventBuffer: #(1 111157 660 444 0 0 0 1)
genieGestureProcessor: nil
keyboardInterpreter: an UTF32InputInterpreter
externalDropMorph: nil

[] in WorldState>>doOneCycleNowFor:
Receiver: a WorldState
Arguments and temporary variables:
<
Receiver's instance variables:
hands: {a HandMorph(1013123)}
activeHand: a HandMorph(1013123)
viewBox: 0@0 corner: 1008@680
canvas: a FormCanvas on: DisplayScreen(1008x680x32)
damageRecorder: a DamageRecorder
stepList: a Heap(StepMessage(#onBlinkCursor -> a TextMorphForEditView(3274035))...etc...
lastStepTime: 3775378560621
lastStepMessage: nil
lastCycleTime: 3775378560643
commandHistory: a CommandHistory
alarms: a MorphicAlarmQueue
lastAlarmTime: 3775378560621
remoteServer: nil
multiCanvas: nil
interCycleDelay: a Delay(20 msecs)

Array(SequenceableCollection)>>do:
Receiver: {a HandMorph(1013123)}
Arguments and temporary variables:
aBlock: [closure] in WorldState>>doOneCycleNowFor:
index: 1
indexLimiT: 1
Receiver's instance variables:
{a HandMorph(1013123)}

WorldState>>handsDo:
Receiver: a WorldState
Arguments and temporary variables:
aBlock: [closure] in WorldState>>doOneCycleNowFor:
Receiver's instance variables:
hands: {a HandMorph(1013123)}
activeHand: a HandMorph(1013123)
viewBox: 0@0 corner: 1008@680
canvas: a FormCanvas on: DisplayScreen(1008x680x32)
damageRecorder: a DamageRecorder
stepList: a Heap(StepMessage(#onBlinkCursor -> a TextMorphForEditView(3274035))...etc...
lastStepTime: 3775378560621
lastStepMessage: nil
lastCycleTime: 3775378560643
commandHistory: a CommandHistory
alarms: a MorphicAlarmQueue
lastAlarmTime: 3775378560621
remoteServer: nil
multiCanvas: nil
interCycleDelay: a Delay(20 msecs)

WorldState>>doOneCycleNowFor:
Receiver: a WorldState
Arguments and temporary variables:
aWorld: a PasteUpMorph(2434915) [world]
capturingGesture: #(false)
Receiver's instance variables:
hands: {a HandMorph(1013123)}
activeHand: a HandMorph(1013123)
viewBox: 0@0 corner: 1008@680
canvas: a FormCanvas on: DisplayScreen(1008x680x32)
damageRecorder: a DamageRecorder
stepList: a Heap(StepMessage(#onBlinkCursor -> a TextMorphForEditView(3274035))...etc...
lastStepTime: 3775378560621
lastStepMessage: nil
lastCycleTime: 3775378560643
commandHistory: a CommandHistory
alarms: a MorphicAlarmQueue
lastAlarmTime: 3775378560621
remoteServer: nil
multiCanvas: nil
interCycleDelay: a Delay(20 msecs)

WorldState>>doOneCycleFor:
Receiver: a WorldState
Arguments and temporary variables:
aWorld: a PasteUpMorph(2434915) [world]
Receiver's instance variables:
hands: {a HandMorph(1013123)}
activeHand: a HandMorph(1013123)
viewBox: 0@0 corner: 1008@680
canvas: a FormCanvas on: DisplayScreen(1008x680x32)
damageRecorder: a DamageRecorder
stepList: a Heap(StepMessage(#onBlinkCursor -> a TextMorphForEditView(3274035))...etc...
lastStepTime: 3775378560621
lastStepMessage: nil
lastCycleTime: 3775378560643
commandHistory: a CommandHistory
alarms: a MorphicAlarmQueue
lastAlarmTime: 3775378560621
remoteServer: nil
multiCanvas: nil
interCycleDelay: a Delay(20 msecs)

PasteUpMorph>>doOneCycle
Receiver: a PasteUpMorph(2434915) [world]
Arguments and temporary variables:

Receiver's instance variables: 
	bounds: 	0@0 corner: 1008@680
	owner: 	nil
	submorphs: 	{a PluggableSystemWindow<Error: Instances of UndefinedObject are not...etc...
	fullBounds: 	0@0 corner: 1008@680
	color: 	(Color r: 0.251 g: 0.259 b: 0.267)
	extension: 	a MorphExtension (931082) [eventHandler = an EventHandler]  [other: ...etc...
	borderWidth: 	0
	borderColor: 	(Color r: 0.515 g: 0.181 b: 0.263)
	presenter: 	an EtoysPresenter (3945455)
	model: 	a MorphicModel(3522854)
	cursor: 	1
	padding: 	3
	backgroundMorph: 	nil
	turtleTrailsForm: 	nil
	turtlePen: 	nil
	lastTurtlePositions: 	nil
	isPartsBin: 	nil
	indicateCursor: 	nil
	wantsMouseOverHalos: 	nil
	worldState: 	a WorldState
	griddingOn: 	nil

[] in MorphicProject>>spawnNewProcess
Receiver: a MorphicProject (HomeProject) in a PasteUpMorph(2434915) [world]
Arguments and temporary variables:

Receiver's instance variables: 
	dependents: 	nil
	world: 	a PasteUpMorph(2434915) [world]
	uiManager: 	a MorphicUIManager
	changeSet: 	a ChangeSet named HomeProject
	transcript: 	a TranscriptStream
	parentProject: 	a MVCProject (RootProject) in a ControlManager
	previousProject: 	nil
	displayDepth: 	32
	viewSize: 	151@132
	thumbnail: 	Form(151x132x32)
	nextProject: 	nil
	projectParameters: 	an IdentityDictionary(#PrevailingProjectFlags->an IdentityDictionary...etc...
	version: 	nil
	urlList: 	nil
	lastDirectory: 	nil
	lastSavedAtSeconds: 	nil
	projectPreferenceFlagDictionary: 	an IdentityDictionary(#showSharedFlaps->true #showWorldMainDockingBar...etc...
	resourceManager: 	a ResourceManager
	uiProcess: 	a Process in nil

[] in FullBlockClosure(BlockClosure)>>newProcess
Receiver: [closure] in MorphicProject>>spawnNewProcess
Arguments and temporary variables:

Receiver's instance variables: 
	outerContext: 	MorphicProject>>spawnNewProcess
	startpcOrMethod: 	([] in MorphicProject>>#spawnNewProcess "a CompiledBlock(15491...etc...
	numArgs: 	0
	receiver: 	a MorphicProject (HomeProject) in a PasteUpMorph(2434915) [world]

• --- The full stack ---
  UndefinedObject(Object)>>error:
  UndefinedObject(Object)>>errorNotIndexable
  UndefinedObject(Object)>>size
  FileDirectory class>>on:
  FileDirectory class>>requestDropDirectory:
  [] in HandMorph>>collectDropFilesAndDirectories:
  Interval>>collect:
  HandMorph>>collectDropFilesAndDirectories:
  HandMorph>>generateDropFilesEvent:
  HandMorph>>processEvents
  [] in WorldState>>doOneCycleNowFor:
  Array(SequenceableCollection)>>do:
  WorldState>>handsDo:
  WorldState>>doOneCycleNowFor:
  WorldState>>doOneCycleFor:
  PasteUpMorph>>doOneCycle
  [] in MorphicProject>>spawnNewProcess
  [] in FullBlockClosure(BlockClosure)>>newProcess

However it's possible that the changeset is using some functionality,
that is somehow not working well on Solaris,
so perhaps it can be independently tested (unrelated to the changes to
the VM or the changeset for dropFile).

That's possible ...

Is it correct to assume that the problem is somehwere in

requestDropDirectory: dropIndex

| potentialDirectory |
potentialDirectory := self on: (FileStream primDropRequestFileName: dropIndex).
^ potentialDirectory exists ifTrue: [potentialDirectory]

The method on: with the FileStream seems to raise an error for me.
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPmtKAAoJEAwpOKXMq1MaBtMIAKqN0Rb+/q38E9cyj6WI0SdW
gGjWhuu1zgs4u/wQQtzDskh3nI57QbN73ytqDPsrX6eRickiYT8MvRQ+ohDqcmfJ
HuNwW1esgL9wM1XGhQ5HOVrs+YxheFeqx5ng8rQqMnHGv82PMUh0zBODY3Us6FMg
fDq+n0rE2GFMFh7E8PoUR7h84O/wg3oXb3tx5g09ebEo8Ftlz+DCGgnCqg2FNhH+
ORNmqRPTIe6y/eJfWdODpCovOnxld///VO6z1Rc1foyGXo5jDAf2N2vdjAH2CXDe
aKXo0RheCV2vM/Jl/lRcYWJh2A/2YvtxbGnb8Dqyz0gQxK2KA6bAg9N4ZyzzX+o=
=2iQV
-----END PGP SIGNATURE-----

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677633726", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677633726", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Oh, I just have realized that I forgot to mention that #514 is another dependency of the changeset. Would you mind to merge it as well into your working copy and compiling the VM again? 😅

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677676218", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677676218", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #508 into Cog.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#event-3679424816", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#event-3679424816", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@cstes Sorry for the delay, Marcel was so kind to merge this by now. I resolved the conflict in #514. Feel free to compile again based on #514 and tell me whether it works for you :-)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-678420198", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-678420198", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>