The Trunk: Morphic-mt.873.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-mt.873.mcz

commits-2
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.873.mcz

==================== Summary ====================

Name: Morphic-mt.873
Author: mt
Time: 14 April 2015, 7:13:14.346 pm
UUID: 425d78a8-53e2-c344-a4cd-82ae0d9926aa
Ancestors: Morphic-mt.872

New color picker morph now uses one-liner for displaying the color expression. It also adds a drop-shadow if menuAppearance3d is enabled.

(Note: There seems to be still some v-scrolling bug... hmmmm...)

=============== Diff against Morphic-mt.872 ===============

Item was changed:
  ----- Method: NewColorPickerMorph>>newColorExpressionMorph (in category 'initialize-release') -----
  newColorExpressionMorph
+ | inputField builder |
+ builder := ToolBuilder default.
+ inputField := (builder build: (builder pluggableInputFieldSpec new
+ model: self;
+ getText: #colorExpression;
+ setText: #colorExpression:)).
+ inputField
- | pluggable |
- pluggable := (PluggableTextMorph
- on: self
- text: #colorExpression
- accept: #colorExpression:)
  hResizing: #spaceFill ;
  vResizing: #rigid ;
+ height: (Preferences standardDefaultTextFont height * 3/2).
+ ^ inputField!
- height: 20 ;
- acceptOnCR: true ;
- retractableOrNot ;
- yourself.
- pluggable textMorph autoFit: false.
- ^ pluggable!

Item was changed:
  ----- Method: NewColorPickerMorph>>setup (in category 'initialize-release') -----
  setup
  self
  color: (Color white slightlyDarker alpha: 0.88) ;
  cornerStyle: #rounded ;
  changeTableLayout ;
  hResizing: #rigid ;
  vResizing: #rigid ;
  extent: 240@240 ;
  addMorphBack: hsvaMorph ;
  addMorphBack: self newColorExpressionMorph ;
  addMorphBack: self newBottomRow ;
  layoutInset: 4 ;
+ cellInset: 2.
+
+ Preferences menuAppearance3d
+ ifTrue: [self addDropShadow].!
- cellInset: 0!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mt.873.mcz

Karl Ramberg
I'm not quite sure what goes wrong with scrolling here.

The horizontal bar does not change in BracketSliderMorph>>initializeSlider
...
          horizontal: self bounds isWide;

Karl

On Tue, Apr 14, 2015 at 7:13 PM, <[hidden email]> wrote:
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.873.mcz

==================== Summary ====================

Name: Morphic-mt.873
Author: mt
Time: 14 April 2015, 7:13:14.346 pm
UUID: 425d78a8-53e2-c344-a4cd-82ae0d9926aa
Ancestors: Morphic-mt.872

New color picker morph now uses one-liner for displaying the color expression. It also adds a drop-shadow if menuAppearance3d is enabled.

(Note: There seems to be still some v-scrolling bug... hmmmm...)

=============== Diff against Morphic-mt.872 ===============

Item was changed:
  ----- Method: NewColorPickerMorph>>newColorExpressionMorph (in category 'initialize-release') -----
  newColorExpressionMorph
+       | inputField builder |
+       builder := ToolBuilder default.
+       inputField := (builder build: (builder pluggableInputFieldSpec new
+               model: self;
+               getText: #colorExpression;
+               setText: #colorExpression:)).
+       inputField
-       | pluggable |
-       pluggable := (PluggableTextMorph
-               on: self
-               text: #colorExpression
-               accept: #colorExpression:)
                 hResizing: #spaceFill ;
                 vResizing: #rigid ;
+                height: (Preferences standardDefaultTextFont height * 3/2).
+       ^ inputField!
-                height: 20 ;
-                acceptOnCR: true ;
-                retractableOrNot ;
-                yourself.
-       pluggable textMorph autoFit: false.
-       ^ pluggable!

Item was changed:
  ----- Method: NewColorPickerMorph>>setup (in category 'initialize-release') -----
  setup
        self
                 color: (Color white slightlyDarker alpha: 0.88) ;
                 cornerStyle: #rounded ;
                 changeTableLayout ;
                 hResizing: #rigid ;
                 vResizing: #rigid ;
                 extent: 240@240 ;
                 addMorphBack: hsvaMorph ;
                 addMorphBack: self newColorExpressionMorph ;
                 addMorphBack: self newBottomRow ;
                 layoutInset: 4 ;
+                cellInset: 2.
+
+       Preferences menuAppearance3d
+               ifTrue: [self addDropShadow].!
-                cellInset: 0!





Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mt.873.mcz

marcel.taeumel (old)
Thank you. This was a regression from my slider refactorings a few days ago.

Should work again: http://forum.world.st/The-Trunk-Morphic-mt-881-mcz-td4819753.html

Best,
Marcel
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mt.873.mcz

Karl Ramberg
That fixed the issue :-)

Karl

On Wed, Apr 15, 2015 at 7:53 PM, Marcel Taeumel <[hidden email]> wrote:
Thank you. This was a regression from my slider refactorings a few days ago.

Should work again:
http://forum.world.st/The-Trunk-Morphic-mt-881-mcz-td4819753.html

Best,
Marcel



--
View this message in context: http://forum.world.st/The-Trunk-Morphic-mt-873-mcz-tp4819573p4819754.html
Sent from the Squeak - Dev mailing list archive at Nabble.com.