Issue 3583 in pharo: Shout should only be active in code panes

Status: Accepted
Owner: [hidden email]
Labels: Type-Patch Milestone-1.2 Importance-High

New issue 3583 by [hidden email]: Shout should only be active in  
code panes
http://code.google.com/p/pharo/issues/detail?id=3583


In the latest Morphic version, the default styler of the PluggableTextMorph  
is given by:
useDefaultStyler
       "This should be changed to a proper registry but as long as there is  
only shout this will do"

       Smalltalk globals
               at: #SHTextStylerST80
               ifPresent: [ :stylerClass | self styler: (stylerClass new  
view: self) ]
               ifAbsent: [ self styler: ( NullTextStyler new view: self) ]

Thus, if Shout is loaded, you will get it in all text morphs by default.  
Given that TextMorph should be general and be used in all sorts of  
contexts, the default behavior should be the original:

useDefaultStyler
        "This should be changed to a proper registry but as long as there is only  
shout this will do"

        self styler: (NullTextStyler new view: self; yourself).

Updates:
        Cc: guillermopolito marcus.denker stephane.ducasse

Comment #1 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

 From Guillermo:

Why not delegate it in the used Editor ?  SmalltalkEditor should use shout  
while the other editors should use the NullTextStyler.  Maybe something  
like this:

PluggableTextMorph>>useDefaultStyler
     self styler: textMorph editor styler

Or better:

PluggableTextMorph>>useDefaultStyler
     self styler: textMorph styler

And then

Editor>>styler
   ^NullTextStyler new

SmalltalkEditor>>styler
   ^...

...

Anyways, I'm looking that

PluggableTextMorph>>textMorphClass
     "Answer the class used to create the receiver's textMorph"

     ^TextMorphForEditView

and

TextMorphForEditView>>editorClass
     ^ SmalltalkEditor


So it's what I suggested needs a lot of work more...

Guille

Comment #2 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Guillermo, could you propose a change set or a slice so that we can work on?

Comment #3 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

And what about a PluggableTextMorph used to display code ? Maybe  
PluggableTextMoprh should have as a parameter during their creation a  
keyword to say if they want to be text styled or not like:

PluggableTextMoprh new beStyled

And by default a PluggableTextMorph isn't styled

Comment #4 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

You can set it simply by #styler:. But, the question is where should this  
decision be taken.

Comment #5 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

With this change set, by default a PluggableTextMorph doesn't style, but  
with beStyled, you make it style again.

It only works with the latest version of shout where PluggableShoutMorph is  
deprecated.

Then we will have to fix tools which needs styling

Attachments:
        FixPluggableTextMorph.1.cs  4.5 KB

Updates:
        Labels: Milestone-1.3

Comment #6 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

(No comment was entered for this change.)

Updates:
        Status: Started

Comment #7 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

12322

TODO: 1.3

Comment #8 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

1319

Comment #9 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

So what is the next step?

Comment #10 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

the next step should be to change class which actually need shout, and to  
specify their UI to styled the text.

I'll take a look as soon as I have enough time :)

Comment #11 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Question1: does this touch Core code or Package in Full?

Question: Is this a show-stopper for a 1.2 release?

Meaning: Could we live wiithout it until a 1.2.1?

Comment #12 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Shout is not a part of the Core, so I think we can live without text  
shouting ^^

For dev image, it could be cool to have it because code colorization is  
really helpful.

But I think it's not long to fix, but I have to work on Hazel this week :)
I will try to take a look this week end

Updates:
        Labels: -Type-Patch -Milestone-1.2 -Milestone-1.3 Milestone-1.2-DevImage

Comment #13 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

So I move this to 1.2Dev

Comment #14 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Here comes a new changeset which finally add shouting in the browser ^^

I've done it like I like to have shouting, but it can be changed easily ^^

Attachments:
        AddShoutingInTools.1.cs  11.9 KB

Comment #15 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Ben should we load the two changeset in 1.3?

Comment #16 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Yes I think, even if the shouting doesn't really matter in a core image,  
but it's another step forward ^^

Comment #17 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

And what about 1.2?

Comment #18 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

not a showstopper so for 1.3.

Stef

Comment #19 on issue 3583 by [hidden email]: Shout should only be  
active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583

Shout looks to work in the OB code browser, but it does not work in the  
Debugger.